Paths

Table of Contentst

Differential D7287

Add simulation node tree type
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 31 2020, 12:27 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB0247ee5f5362: Simulations: Add simulation node tree type

Summary

This implements a new builtin node tree type called SimulationNodeTree.
It is not yet embedded in the Simulation data block.

This is part of T73324.

The WITH_NEW_SIMULATION_TYPE cmake option is used to control whether Simulation Editor is shown in the editors menu.
Disabling the rna code with this option was a bit tricky, because the node tree type stores a reference to the rna type.
I could do the #ifdef WITH_NEW_SIMULATION_TYPE everywhere, but I'm not sure if it is worth the effort.

Currently there is only the group node, which is unusable, because there are no other nodes.
I'll submit those for review separately.

Diff Detail

Repository

Branch

simulation-tree-arc (branched from master)

Build Status

Buildable 7513
Build 7513: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Mar 31 2020, 12:27 PM

Harbormaster completed remote builds in B7377: Diff 23290.Mar 31 2020, 12:27 PM

Jacques Lucke (JacquesLucke) added a parent revision: D7225: Add new simulation data block.Mar 31 2020, 12:29 PM

Looks good, except you need to add license headers to new files.

This revision is now accepted and ready to land.Mar 31 2020, 10:01 PM

add license headers

Harbormaster completed remote builds in B7399: Diff 23337.Apr 1 2020, 10:53 AM

Not sure if this fixes the diff...

Harbormaster completed remote builds in B7400: Diff 23338.Apr 1 2020, 10:54 AM

Brecht Van Lommel (brecht) accepted this revision.Apr 1 2020, 11:52 AM

Jacques Lucke (JacquesLucke) added a child revision: D7301: Embed simulation node tree in simulation data block.Apr 1 2020, 12:33 PM

update for latest master

Harbormaster completed remote builds in B7476: Diff 23467.Apr 6 2020, 12:02 PM

add missing enum item
Merge branch 'simulation-data-block' into simulation-tree-arc

Harbormaster completed remote builds in B7513: Diff 23583.Apr 9 2020, 11:31 AM

Closed by commit rB0247ee5f5362: Simulations: Add simulation node tree type (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 20 2020, 11:07 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB0247ee5f5362: Simulations: Add simulation node tree type.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

8 lines

editors/

include/

1 line

space_node/

4 lines

9 lines

6 lines

9 lines

5 lines

makesdna/

DNA_node_types.h

1 line

makesrna/

2 lines

intern/

65 lines

nodes/

7 lines

8 lines

	NOD_simulation.h/
	intern/


	node_common.h

26 lines

intern/

8 lines

8 lines

	simulation/
	intern/

	node_simulation_tree.cc
	node_common.h

37 lines

	node_simulation_util.h
	node_common.h

32 lines

	node_simulation_util.cc
	node_common.h

29 lines

simulation/

nodes/

node_sim_common.cc

45 lines

Diff 23583

source/blender/blenkernel/intern/node.c

Loading...

source/blender/editors/include/ED_node.h

Loading...

source/blender/editors/space_node/CMakeLists.txt

Loading...

source/blender/editors/space_node/drawnode.c

Loading...

source/blender/editors/space_node/node_edit.c

Loading...

source/blender/editors/space_node/node_group.c

Loading...

source/blender/editors/space_node/space_node.c

Loading...

source/blender/makesdna/DNA_node_types.h

Loading...

source/blender/makesrna/RNA_access.h

Loading...

source/blender/makesrna/intern/rna_nodetree.c

Loading...

source/blender/nodes/CMakeLists.txt

Loading...

source/blender/nodes/NOD_common.h

Loading...

source/blender/nodes/NOD_simulation.h

Loading...

source/blender/nodes/intern/node_common.h

Loading...

source/blender/nodes/intern/node_util.h

Loading...

source/blender/nodes/simulation/node_simulation_tree.cc

Loading...

source/blender/nodes/simulation/node_simulation_util.h

Loading...

source/blender/nodes/simulation/node_simulation_util.cc

Loading...

source/blender/nodes/simulation/nodes/node_sim_common.cc

Loading...