Fix T72688: Vertex Group Weights in Edit Mode Occludes In Front Armatures
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 31 2020, 3:39 PM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T72688: Vertex Group Weights in Edit Mode Occludes In Front Armatures

Commits

rB782e6ea4edd9: Fix T72688: Vertex Group Weights in Edit Mode Occludes In Front Armatures

Summary

Due to legacy this overlay was implemented twice (Edit Mesh and Weight
Painting) with different results. This patch consolidates both drawing
and uses only the Weight Painting drawing.

Diff Detail

Repository

rB Blender

Branch

T72688 (branched from master)

Build Status

Buildable 7384
Build 7384: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Mar 31 2020, 3:39 PM

Harbormaster completed remote builds in B7384: Diff 23299.Mar 31 2020, 3:40 PM

Cleanup unneeded compares

Harbormaster completed remote builds in B7385: Diff 23300.Mar 31 2020, 3:43 PM

Minor style comment but this is good.

source/blender/draw/engines/overlay/overlay_engine.c
113	Style: Move this to line 109
source/blender/draw/engines/overlay/overlay_paint.c
79–80	Should be `!is_edit_mode` for readability
89	Style: Add `const bool is_edit_mode = (pd->ctx_mode == CTX_MODE_EDIT_MESH);` at line 78 and use it for readability.