Add Voxel Mode to the Remesh modifier
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Mar 31 2020, 4:30 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB6c036a65c974: Add Voxel Mode to the Remesh modifier

Summary

This adds the Voxel Mode to the current remesh modifier. It works
exactly the same way as the voxel remesh operator and uses the same
properties to control the remeshing. We can exand this with more options
in the future (fix poles, reprojection...)

Diff Detail

Repository

rB Blender

Branch

remesh-modifier (branched from master)

Build Status

Buildable 7389
Build 7389: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Mar 31 2020, 4:30 PM

Harbormaster completed remote builds in B7389: Diff 23310.Mar 31 2020, 4:30 PM

Pablo Dobarro (pablodp606) added a reviewer: Brecht Van Lommel (brecht).Mar 31 2020, 4:31 PM

Pablo Dobarro (pablodp606) mentioned this in D4960: New Voxel Mesher Modifier.

Reinhard Kepplinger (ReinhardK) awarded a token.Mar 31 2020, 4:47 PM

Reinhard Kepplinger (ReinhardK) added a subscriber: Reinhard Kepplinger (ReinhardK).

Looks good, except this is missing initialization of the properties in the modifier initData and in versioning.

I think we should also consider making Voxel the default mode for the Remesh modifier.

This revision now requires changes to proceed.Mar 31 2020, 4:51 PM

serge (rpserge) awarded a token.Mar 31 2020, 4:53 PM

Add init and versioning, make Voxel the default mode.

Harbormaster completed remote builds in B7390: Diff 23311.Mar 31 2020, 5:06 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Mar 31 2020, 5:28 PM

Brecht Van Lommel (brecht) accepted this revision.Mar 31 2020, 5:46 PM

This revision is now accepted and ready to land.Mar 31 2020, 5:46 PM

Closed by commit rB6c036a65c974: Add Voxel Mode to the Remesh modifier (authored by Pablo Dobarro (pablodp606)). · Explain WhyMar 31 2020, 6:28 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB6c036a65c974: Add Voxel Mode to the Remesh modifier.

Henrik Dick (weasel) awarded a token.Mar 31 2020, 8:34 PM

item412 (item412) awarded a token.Apr 1 2020, 4:18 PM

Fran Marz (franMarz) awarded a token.Apr 7 2020, 1:00 PM

In D7292#174845, @Pablo Dobarro (pablodp606) wrote:

Add init and versioning, make Voxel the default mode.

Sorry people, first time here. I hope I'm not messing up things.
Great work @Pablo Dobarro (pablodp606) and @Brecht Van Lommel (brecht) but I think making the Voxel the default mode can lead to machine freezing on large mesh.

Current size is 0,1m, if I would like to remesh a terrain, I have to use a dummy object to set up the modifier.
Octree depth was less harmful on all kind of meshes. I suggest to switch back to Smooth or Sharp....

Here's an extensive post on devtalk https://devtalk.blender.org/t/voxel-mode-for-remesh-modifier-should-not-be-the-default/16598

@Carlo Bergonzini (Monorender) there's a bug report at T77868: Remesh Voxel Size can be much to small by default (leading to crashes). 'Edit Voxel Size' operator can have wrong range for that

In D7292#245068, @Ankit Meel (ankitm) wrote:

@Carlo Bergonzini (Monorender) there's a bug report at T77868: Remesh Voxel Size can be much to small by default (leading to crashes). 'Edit Voxel Size' operator can have wrong range for that

Thanks for pointing it out @Ankit Meel (ankitm), but reading the review I couldn't find any reference to the problem of adding the Voxel remesh to large objects.
My issue is not a bug, or a crash, or soft limits isssue, everything is working fine: it's just not a good idea to use Voxel remesh option, which works on absolute units, as the default.

I think the ones with Octree are more agile and currently a better choiche as default.

Am I missing something? Is it already planned there to switch back to one of those modes?