Page MenuHome
Differential D7327

Cleanup: don't use global variable for test if IDs are identical
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Apr 3 2020, 5:14 PM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rB44e5f7a8cfc0: Cleanup: don't use global variable for test if IDs are identical
Summary

Depends on D7326

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Apr 3 2020, 5:14 PM
Harbormaster completed remote builds in B7440: Diff 23403.Apr 3 2020, 5:14 PM
Brecht Van Lommel (brecht) added a child revision: D7328: Cleanup: delay creating datamap until it's actually needed.Apr 3 2020, 5:16 PM
Bastien Montagne (mont29) accepted this revision.Apr 6 2020, 12:30 PM

Well, this is adding one extra loop potentially over the whole file content... Not sure am thrilled by that, but on the other end I guess this will not be a performance issue, and it does make the code a bit cleaner.

This revision is now accepted and ready to land.Apr 6 2020, 12:30 PM
Brecht Van Lommel (brecht) added a comment.Apr 6 2020, 3:00 PM

Since this makes D7328 possible, I think it will be faster in the average case where you don't need to do a memory allocation and memcpy for the entire ID memory.

This can be optimized later too. I think we should really be storing bheads grouped per ID somehow, and then it would be easy to have a single boolean stored per ID to indicate if it's identical or not.

Bastien Montagne (mont29) added a comment.Apr 6 2020, 3:01 PM
In D7327#176094, @Brecht Van Lommel (brecht) wrote:

This can be optimized later too. I think we should really be storing bheads grouped per ID somehow, and then it would be easy to have a single boolean stored per ID to indicate if it's identical or not.

Indeed!

Closed by commit rB44e5f7a8cfc0: Cleanup: don't use global variable for test if IDs are identical (authored by Brecht Van Lommel (brecht)). · Explain WhyApr 7 2020, 1:24 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB44e5f7a8cfc0: Cleanup: don't use global variable for test if IDs are identical.

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
5 lines
40 lines

Diff 23512

View Options

source/blender/blenloader/intern/readfile.h

Loading...
View Options

source/blender/blenloader/intern/readfile.c

Loading...