Cleanup: simplify logic for partial undo in ID read
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on Apr 3 2020, 5:17 PM.

Details

Reviewers

Commits

rB7bc99fdb322c: Cleanup: simplify logic for partial undo in ID read

Summary

This assumes (id->lib == NULL) is testing the same thing as
(bhead->code != ID_LINK_PLACEHOLDER). Even if there might be cases where
they are out of sync, I can't imagine why we would want to handle them
differently.

Depends on D7329

Diff Detail

Repository: rB Blender

Event Timeline

Brecht Van Lommel (brecht) created this revision.Apr 3 2020, 5:17 PM

Harbormaster completed remote builds in B7443: Diff 23406.Apr 3 2020, 5:18 PM

Brecht Van Lommel (brecht) added a child revision: D7331: Cleanup: split partial undo code off into functions, tweak debug prints.Apr 3 2020, 5:18 PM

Bastien Montagne (mont29) accepted this revision.Apr 6 2020, 3:26 PM

This revision is now accepted and ready to land.Apr 6 2020, 3:26 PM

Closed by commit rB7bc99fdb322c: Cleanup: simplify logic for partial undo in ID read (authored by Brecht Van Lommel (brecht)). · Explain WhyApr 7 2020, 1:24 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB7bc99fdb322c: Cleanup: simplify logic for partial undo in ID read.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenloader/

intern/

readfile.c

174 lines

Diff 23515

View Options

source/blender/blenloader/intern/readfile.c

Cleanup: simplify logic for partial undo in ID readClosedPublicActions