Page MenuHome
Differential D7333

Fix T75343: Wireframe overylay is not working properly with multiple modifiers
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 4 2020, 11:16 AM.

Details

Reviewers
Jeroen Bakker (jbakker)
Clément Foucault (fclem)
Maniphest Tasks
T75343: Wireframe overylay is not working properly with multiple modifiers
Commits
rB5e0465e4ecba: Fix T75343: Wireframe overylay is not working properly with multiple modifiers
Summary

Since rBcf258b02f449, only wires and edges that are mapped to the
original mesh were drawn if the mesh was modified by modifiers.
Above commit was only meant for showing orig wires for paint mask
overlays [where final wireframe is not desired], so now only use
MR_EXTRACT_MAPPED when we are in a paint mode.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Apr 4 2020, 11:16 AM
Harbormaster completed remote builds in B7452: Diff 23419.Apr 4 2020, 11:16 AM
Vyacheslav (hitrpr) awarded a token.Apr 4 2020, 1:07 PM
Jeroen Bakker (jbakker) accepted this revision.Apr 7 2020, 11:30 AM

I'm ok with the change. I tested edge cases that I was aware off.

This revision is now accepted and ready to land.Apr 7 2020, 11:30 AM
Closed by commit rB5e0465e4ecba: Fix T75343: Wireframe overylay is not working properly with multiple modifiers (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 7 2020, 2:53 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB5e0465e4ecba: Fix T75343: Wireframe overylay is not working properly with multiple modifiers.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
1 line
16 lines
3 lines

Diff 23526

View Options

source/blender/draw/intern/draw_cache_extract.h

Loading...
View Options

source/blender/draw/intern/draw_cache_extract_mesh.c

Loading...
View Options

source/blender/draw/intern/draw_cache_impl_mesh.c

Loading...