Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Group Reviewers

Modifiers

Commits

rB35b1cc806f76: Improve Solidify/Bevel Modifier cooperation

Summary

This patch adds a slider to solidify which allows the user to add bevel weight on the outside or remove bevel weight from the inside.
A quick demo of what can be done now:

This model uses Solidify and Bevel Modifier. Look at the edges how the bevel only is applied from the outside.

Also included in this patch is a very small improvment for working with subsurface modifier where the rim edge in complex solidify will now also have a chance to get a crease if there is only two adjacent edges.

This patch is based on D7224 and should land after that one.

Diff Detail

Repository: rB Blender

Event Timeline

Henrik Dick (weasel) created this revision.Apr 4 2020, 2:24 PM

Applied clang format

Hans Goudey (HooglyBoogly) awarded a token.Apr 4 2020, 3:31 PM

fixed some artifacts

Arian (14AUDDIN) awarded a token.Apr 4 2020, 4:12 PM

Dspazio (Dspazio) awarded a token.Apr 4 2020, 4:29 PM

I think now I've got every artifact fixed for non manifold (complex) mode

I will look into extrude/simple solidify now, but probably it will stay different from complex solidify in how it handles bevel weights

While playing with it I found a very weird behaviour of the bevel modifier. I will make a bug report about that.

fixed a crash when using solidify simple.

At this point everything seems to work. The behavior for simple solidify rims is still the same as before though. I could implement the same behaviour as for complex solidify, but that would make old files look different. As complex solidify is very new still I think its fine for that one to change for the better, but as simple solidify has a long history, a lot of people rely on how it works (I don't know if anybody used it with bevel weights though). So I would need feedback before changing anything like that.

Fran Marz (franMarz) awarded a token.Apr 4 2020, 9:44 PM

Henrik Dick (weasel) mentioned this in D7340: Add Complex Solidify option for thickness per face.Apr 5 2020, 8:21 PM

From quick skimming over code things look good. Was not able to apply the patch on current master though, can you please update it (as well as D7340)?

source/blender/modifiers/intern/MOD_solidify_extrude.c
238	`0.0f` ;)
source/blender/modifiers/intern/MOD_solidify_nonmanifold.c
1803	`0.0f` ;)

rebase
tiny modifications

There is one little adjustment I still need to make for complex mode rim bevel weights. (I noticed it right now)
Will probably be done til tomorrow.

fixed bweight distribution for non manifold edges

Harbormaster completed remote builds in B7561: Diff 23699.Apr 13 2020, 11:29 PM

clang format

Harbormaster completed remote builds in B7562: Diff 23700.Apr 13 2020, 11:32 PM

Nahuel Belich (belich) awarded a token.Apr 14 2020, 12:35 AM

Bastien Montagne (mont29) accepted this revision.Apr 14 2020, 11:18 AM

This revision is now accepted and ready to land.Apr 14 2020, 11:18 AM

Closed by commit rB35b1cc806f76: Improve Solidify/Bevel Modifier cooperation (authored by Henrik Dick (weasel), committed by Bastien Montagne (mont29)). · Explain WhyApr 14 2020, 12:19 PM

This revision was automatically updated to reflect the committed changes.

Bastien Montagne (mont29) added a commit: rB35b1cc806f76: Improve Solidify/Bevel Modifier cooperation.

Hi! I was trying the commit and I noticed a couple of problems. I thought it was better to just list them here instead of filling bug reports.

in Simple mode a Bevel value different than 0 with Fill Rim disabled results in instant crash
in Simple mode the slider doesn't work if the edge weight is not initialized yet (setting the weight to any value other than 0 activates it)

Tested on the default cube.

In D7334#177847, @Alessio Monti di Sopra (a.monti) wrote:

Hi! I was trying the commit and I noticed a couple of problems. I thought it was better to just list them here instead of filling bug reports.

in Simple mode a Bevel value different than 0 with Fill Rim disabled results in instant crash

in Simple mode the slider doesn't work if the edge weight is not initialized yet (setting the weight to any value other than 0 activates it)

Tested on the default cube.

Thanks for the bug report, will take a look at that as soon as possible.
You could have filed a normal bug report instead and added me as subscriber mentioning this diff, but anyway.

Felix (Lonke) awarded a token.Apr 17 2020, 7:11 PM

Henrik Dick (weasel) mentioned this in D7463: Fix T75840: Add check for not generated edges.Apr 17 2020, 9:59 PM

Bastien Montagne (mont29) mentioned this in rB7865185d9865: Fix T75840: Add check for not generated edges.Apr 20 2020, 4:18 PM

Henrik Dick (weasel) mentioned this in T81331: Complex Solidify TODO.Sep 30 2020, 6:36 PM

Improve Solidify/Bevel Modifier cooperation
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 23423

release/scripts/startup/bl_ui/properties_data_modifier.py

source/blender/makesdna/DNA_modifier_types.h

source/blender/makesrna/intern/rna_modifier.c

source/blender/modifiers/intern/MOD_solidify.c

source/blender/modifiers/intern/MOD_solidify_extrude.c

source/blender/modifiers/intern/MOD_solidify_nonmanifold.c

Improve Solidify/Bevel Modifier cooperationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 23423

release/scripts/startup/bl_ui/properties_data_modifier.py

source/blender/makesdna/DNA_modifier_types.h

source/blender/makesrna/intern/rna_modifier.c

source/blender/modifiers/intern/MOD_solidify.c

source/blender/modifiers/intern/MOD_solidify_extrude.c

source/blender/modifiers/intern/MOD_solidify_nonmanifold.c

Improve Solidify/Bevel Modifier cooperation
ClosedPublic
Actions

Revision Contents
Changeset List