Archipack thumbnail generation - Access shader node by name instead of index
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Apr 4 2020, 11:54 PM.

Details

Reviewers

stephen leger (stephen_leger)
Brendon Murphy (meta-androcto)
Campbell Barton (campbellbarton)

Maniphest Tasks

T75393: Archipack thumbnail generation fails - Wrong node accessed by index

Commits

rBAba19a9a74770: Fix T75393: Archipack thumbs find shader node by type

Summary

Fixes T75393 by accessing the Principled BSDF by name, instead of assuming that it's the node with index 1.

Diff Detail

Repository

rBA Blender Add-ons

Branch

2020-04-04-fix-archipack-thumb-material

Build Status

Buildable 7461
Build 7461: arc lint + arc unit

Event Timeline

Robert Guetzkow (rjg) created this revision.Apr 4 2020, 11:54 PM

Harbormaster completed remote builds in B7456: Diff 23431.Apr 4 2020, 11:54 PM

Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)Apr 4 2020, 11:55 PM

Robert Guetzkow (rjg) edited the summary of this revision. (Show Details)

Would iterate over nodes and retrieve by type instead,
as nodes names depends on translation.
eg Ukrain BSDF node name -> 'Принципове BSDF'

This revision now requires changes to proceed.Apr 5 2020, 1:02 AM

@stephen leger (stephen_leger) Good point. Will update the patch tomorrow.

Find the Principled BSDF by type instead of name, which would cause problems with internationalization

Harbormaster completed remote builds in B7461: Diff 23436.Apr 5 2020, 12:01 PM

Replace access by name for base color with access by index

Harbormaster completed remote builds in B7462: Diff 23437.Apr 5 2020, 12:04 PM

stephen leger (stephen_leger) accepted this revision.Apr 5 2020, 1:01 PM

This revision is now accepted and ready to land.Apr 5 2020, 1:01 PM

Arian (14AUDDIN) awarded a token.Apr 5 2020, 1:30 PM

Closed by commit rBAba19a9a74770: Fix T75393: Archipack thumbs find shader node by type (authored by Robert Guetzkow (rjg)). · Explain WhyApr 5 2020, 2:26 PM

This revision was automatically updated to reflect the committed changes.

Robert Guetzkow (rjg) added a commit: rBAba19a9a74770: Fix T75393: Archipack thumbs find shader node by type.

Revision Contents
Changeset List

Path

Size

archipack/

archipack_thumbs.py

5 lines

Diff 23436

View Options

archipack/archipack_thumbs.py

Archipack thumbnail generation - Access shader node by name instead of indexClosedPublicActions