Differential D7361

Fix crash using object.to_mesh() when in edit mode
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Apr 7 2020, 11:40 AM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)
Gaia Clary (gaiaclary)

Maniphest Tasks

T75371: calling evaluated_depsgraph_get() while active object in EDIT mode can crash Blender

Commits

rB9fca9b995349: Fix crash using object.to_mesh() when in edit mode

Summary

The root of the issue was caused by mesh which was a result of to_mesh()
had the same edit_mesh pointer as the input object, causing double-free
error.

This fix makes it so result mesh does not have edit mesh pointer.
Motivation part behind this is to make the result of to_mesh() to be
somewhat independent from the input.

Diff Detail

Repository

Branch

fix_T75371 (branched from master)

Build Status

Buildable 7491
Build 7491: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) created this revision.Apr 7 2020, 11:40 AM

Harbormaster completed remote builds in B7491: Diff 23505.Apr 7 2020, 11:40 AM

Brecht Van Lommel (brecht) accepted this revision.Apr 7 2020, 11:50 AM

Brecht Van Lommel (brecht) added a task: T75371: calling evaluated_depsgraph_get() while active object in EDIT mode can crash Blender.

This revision is now accepted and ready to land.Apr 7 2020, 11:50 AM

I have tested that the fix works on my test case. So i guess its all good. Thanks !

Closed by commit rB9fca9b995349: Fix crash using object.to_mesh() when in edit mode (authored by Sergey Sharybin (sergey)). · Explain WhyApr 7 2020, 12:51 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB9fca9b995349: Fix crash using object.to_mesh() when in edit mode.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

12 lines

Diff 23505

source/blender/blenkernel/intern/mesh_convert.c

Loading...