Page MenuHome
Differential D7364

Archipack floor, recalcuate normals before beveling to avoid zero normal
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Apr 7 2020, 1:41 PM.

Details

Reviewers
stephen leger (stephen_leger)
Campbell Barton (campbellbarton)
Maniphest Tasks
T75394: Archipack floor preset crashes Blender debug build
Commits
rBAfb6d7c4ed81b: Fix T75394: Archipack update normals before beveling
Summary

This patch fixes T75394 where an assert was triggered because a normal was zero in all components. Updating the normals for the bmesh avoids this.

Diff Detail

Repository
rBA Blender Add-ons
Branch
2020-04-06-archipack-floor-normal
Build Status
Buildable 7494
Build 7494: arc lint + arc unit

Event Timeline

Robert Guetzkow (rjg) created this revision.Apr 7 2020, 1:41 PM
Harbormaster completed remote builds in B7494: Diff 23519.Apr 7 2020, 1:41 PM
stephen leger (stephen_leger) accepted this revision.Apr 7 2020, 2:08 PM
This revision is now accepted and ready to land.Apr 7 2020, 2:08 PM
Closed by commit rBAfb6d7c4ed81b: Fix T75394: Archipack update normals before beveling (authored by Robert Guetzkow (rjg)). · Explain WhyApr 7 2020, 3:45 PM
This revision was automatically updated to reflect the committed changes.
Robert Guetzkow (rjg) added a commit: rBAfb6d7c4ed81b: Fix T75394: Archipack update normals before beveling.

Revision Contents
Changeset List

PathSize
archipack/
2 lines

Diff 23519

View Options

archipack/archipack_floor.py

Loading...