Sculpt: Face Set Edit Operator
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Apr 7 2020, 4:17 PM.

Details

Reviewers

Jeroen Bakker (jbakker)
Sergey Sharybin (sergey)

Commits

rBcb9de95d61b3: Sculpt: Face Set Edit Operator

Summary

This operator performs an edit operation in the active face set defined
by the cursor position and updates the visibility. For now, it has a
Grow and Shrink operations, similar to Select More/Less in edit mode or
to the mask filter Grow/Shrink modes. More operations can be added in
the future.

In multires, this updates the visibility of an entire face from the base
mesh at once, which makes it very convenient to edit the visible area
without manipulating the face set directly.

Diff Detail

Repository

rB Blender

Branch

sculpt-face-set-edit (branched from master)

Build Status

Buildable 8305
Build 8305: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Apr 7 2020, 4:17 PM

Harbormaster completed remote builds in B7498: Diff 23530.Apr 7 2020, 4:18 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Apr 7 2020, 4:18 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).

Erick Tukuniata (erickblender) awarded a token.Apr 7 2020, 4:21 PM

Ruslan (Loner) awarded a token.Apr 7 2020, 4:27 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Apr 7 2020, 4:29 PM

Jun Mizutani (jmztn) awarded a token.Apr 7 2020, 7:31 PM

Jun Mizutani (jmztn) added a subscriber: Jun Mizutani (jmztn).

Lopo Isaac (lopoIsaac) awarded a token.Apr 7 2020, 11:34 PM

noki paike (amonpaike) awarded a token.Apr 8 2020, 1:43 AM

Metin Seven (MetinSeven) awarded a token.Apr 8 2020, 11:29 AM

Tonatiuh de San Julián (Tonatiuh) awarded a token.Apr 8 2020, 11:47 AM

Pablo Dobarro (pablodp606) added a project: BF Blender (2.83).Apr 8 2020, 12:44 PM

Andrey (andruxa696) awarded a token.May 1 2020, 12:18 AM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).May 27 2020, 1:41 AM

What I don't understand here is why you're using BMesh? Such conversion is not cheap. If it is for neighborhood information I think BKE_mesh_mapping.h is for the help here.
You can double-check with Bastien or Campbell whether BKE_mesh_mapping is indeed more memory/performance friendly.

source/blender/editors/sculpt_paint/sculpt_face_set.c
1069	Why do you need normals?
1075	Some notes: If you're overriding all elements use `malloc` semantic. If you're allocating array use array allocation semantic (`MEM_calloc_arrayN`, `MEM_malloc_arrayN`). If you need copy of entire managed memory block use `MEM_dupallocN`. If you need to copy an entire buffer from unmanaged source to your memory use `memcpy`.

-Review Update: Use mesh map instead of BMesh

Harbormaster completed remote builds in B8305: Diff 25269.May 31 2020, 12:41 AM

Sergey Sharybin (sergey) added inline comments.Jun 2 2020, 10:10 AM

source/blender/editors/sculpt_paint/sculpt_face_set.c
1020	Why `abs` is used on the face set?

Pablo Dobarro (pablodp606) added inline comments.Jun 2 2020, 10:13 PM

source/blender/editors/sculpt_paint/sculpt_face_set.c
1020	Because its visibility is encoded in the integer sign and this just needs to compare IDs

Sergey Sharybin (sergey) added inline comments.Jun 3 2020, 11:23 AM

source/blender/editors/sculpt_paint/sculpt_face_set.c
1020	I would say that: `SculptSession::face_sets` should be commented with this information . Better naming is to be used, to make it clear whether visibility is encoded or not. The least resistant path seems to be to consider `face_set`to always be an encoded face set id + visibility, and when visibility is not included call it `face_set_id`. So here it would be: if (abs(prev_face_sets[neighbor_face_index]) == active_face_set_id) {