Fix color drag and drop in the image editor
AbandonedPublic
Actions

Authored by Robert Guetzkow (rjg) on Apr 7 2020, 10:44 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Sybren A. Stüvel (sybren)
Sergey Sharybin (sergey)

Maniphest Tasks

T72476: Assert Dragging & dropping color in the Image Editor (double UNDO push?)

Commits

rBbb1e794d5800: Fix T72476: Crash when drag & drop Color in the Image Editor

Summary

This patch fixes T72476 by removing the redundant init of the undo. Additionally the paint_2d_bucket_fill() has been modified to avoid dereferencing of a NULL pointer.

Diff Detail

Repository

rB Blender

Branch

2020-04-07-fix-color-drag-n-drop (branched from master)

Build Status

Buildable 7499
Build 7499: arc lint + arc unit

Event Timeline

Robert Guetzkow (rjg) created this revision.Apr 7 2020, 10:44 PM

Harbormaster completed remote builds in B7499: Diff 23539.Apr 7 2020, 10:44 PM

Robert Guetzkow (rjg) added a reviewer: Sergey Sharybin (sergey).Apr 9 2020, 1:30 PM

The fix works for me and seems reasonable. However, I don't know the undo code much either.

source/blender/editors/sculpt_paint/paint_image.c
1308	`wm` is unused.

Robert Guetzkow (rjg) added inline comments.Apr 21 2020, 4:22 PM

source/blender/editors/sculpt_paint/paint_image.c
1308	Well spotted, you're right.

Remove unused variable

Harbormaster completed remote builds in B7664: Diff 23950.Apr 21 2020, 10:39 PM

Robert Guetzkow (rjg) marked an inline comment as done.Apr 21 2020, 10:39 PM

Robert Guetzkow (rjg) added a commit: rBbb1e794d5800: Fix T72476: Crash when drag & drop Color in the Image Editor.Apr 27 2020, 11:18 AM

This change was already committed by @Campbell Barton (campbellbarton) before the revision was marked as accepted.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

sculpt_paint/

paint_image.c

15 lines

paint_image_2d.c

6 lines

Diff 23539

View Options

source/blender/editors/sculpt_paint/paint_image.c