Fixing feedback in the status bar for saved .blend files
ClosedPublic
Actions

Authored by Roberto Lopes (XDroid) on Apr 8 2020, 12:18 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Bastien Montagne (mont29)

Summary

For my first commit in Blender, I want to fix this annoying issue for the "Report Message" in the status bar.

This issue appears in two ways :

For the first time you save a .blend file, there is no feedback in order to know that the .blend file has been correctly saved.
If the .blend file cannot be saved because of a non-listed error on Blender (such as the "No space left on device", error number 28, error code ENOSPC) ; in other word, if the write_file_handle function returns true, the status bar feedback is incorrect ("Saved "X.blend" insteed of the error description) because the "Saved "X.blend" message overwrite the previous error message :

So, if we move the mouve in the same time, the error popup doesn't appear and the user is misled by this wrong message in the status bar.
Then, we can close Blender with no unsaved .blend alert message.

Futhermore, if an unknow error appears such as "No space left on device", the tempfile (.blend@) isn't deleted. My patch doesn't fix this issue.

Diff Detail

Repository: rB Blender

Event Timeline

Roberto Lopes (XDroid) created this revision.Apr 8 2020, 12:18 AM

Campbell Barton (campbellbarton) mentioned this in rB1c5831144040: Fix status bar message showing saved when saving failed.Apr 8 2020, 5:29 AM

Good catch, committed rB1c5831144040709380e02fc41ddef2e10d998cda

I moved the message into wm_file_write as having this in BLO_write_file caused it to print messages for auto-save, save-on-exit, preferences and writing copy-buffer.

From testing this addresses all the issues you raised in this report.

This revision is now accepted and ready to land.Apr 8 2020, 5:32 AM

Campbell Barton (campbellbarton) closed this revision.Apr 8 2020, 5:32 AM