UI: English as Default Language
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Apr 8 2020, 2:26 AM.

Details

Reviewers

Commits

rB7df787b2c197: UI: English as Default Language

Summary

With recent changes to Language selection, https://developer.blender.org/D7210, we are deprecating the "Translate" (USER_DOTRANSLATE) flag and favoring a default language of English (id=1), rather than Auto (id=0).

We dealt with the situation of users having old preferences in versioning_userdef.c but I forgot to address the situation of preferences not existing at all. In that case, of a brand new user, we want the language to start at English, not Auto. This patch makes that change by setting this value in userdef_default.c

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) created this revision.Apr 8 2020, 2:26 AM

Brecht Van Lommel (brecht) accepted this revision.Apr 8 2020, 11:45 AM

This revision is now accepted and ready to land.Apr 8 2020, 11:45 AM

Should the default setting not be American (English)? The tooltip show's en_US?

People seeing English (English) would expect the tooltip to show en_UK, and things like 'Color Management' to be 'Colour Management'.

@Adrian Newton (TFS) - Should the default setting not be American (English)? The tooltip show's en_US?

There might be ways to improve what is displayed, and the tooltip too, but this patch is not about that. This patch is more about changing from a default that means "automatically detect language, and possibly select one that we don't even support and therefore break" to one that means "this is the default language that blender is written in so don't bother replacing any of the UI strings". LOL.

Closed by commit rB7df787b2c197: UI: English as Default Language (authored by Harley Acheson (harley)). · Explain WhyApr 9 2020, 1:20 AM

This revision was automatically updated to reflect the committed changes.

Harley Acheson (harley) added a commit: rB7df787b2c197: UI: English as Default Language.