Sculpt: Pose Brush Scale/Transform deform mode
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Apr 8 2020, 2:31 AM.

Details

Reviewers

Jeroen Bakker (jbakker)
Julien Kaspar (JulienKaspar)
Sergey Sharybin (sergey)

Commits

rB6d4dc22e17a7: Sculpt: Pose Brush Scale/Transform deform mode

Summary

This is an alternative deformation brush for the Pose Brush intended
quickly change the proportions of the mesh. The regular mode scales
using the segment's origin as a pivot. The inverted mode drags the
entire segment using the grab delta.

The only difference with the regular pose brush is that it is not
compatible with IK, so the option is disabled and set to 1 segment. The
rest of the options should work as expected.

Diff Detail

Repository

rB Blender

Branch

sculpt-pose-scale-transform (branched from master)

Build Status

Buildable 7501
Build 7501: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Apr 8 2020, 2:31 AM

Harbormaster completed remote builds in B7501: Diff 23547.Apr 8 2020, 2:31 AM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Apr 8 2020, 2:32 AM

Pablo Dobarro (pablodp606) added reviewers: Jeroen Bakker (jbakker), Julien Kaspar (JulienKaspar).

Kenn Nyström (Frozen_Death_Knight) awarded a token.Apr 8 2020, 2:39 AM

AnityEx (AnityEx) awarded a token.Apr 8 2020, 3:20 AM

Thecave Lap (thecavelap) awarded a token.Apr 8 2020, 6:10 AM

Alex Smith (asmitty) awarded a token.Apr 8 2020, 6:26 AM

Matjaž Lamut (lamoot) awarded a token.Apr 8 2020, 10:43 AM

Pablo Dobarro (pablodp606) added a project: BF Blender (2.83).Apr 8 2020, 12:45 PM

Joseph Brandenburg (TheAngerSpecialist) awarded a token.Apr 9 2020, 4:45 PM

Pablo Dobarro (pablodp606) added a reviewer: Sergey Sharybin (sergey).May 18 2020, 1:58 AM

TheRedWaxPolice (TheRedWaxPolice) awarded a token.May 18 2020, 3:34 AM

TheRedWaxPolice (TheRedWaxPolice) added a subscriber: TheRedWaxPolice (TheRedWaxPolice).

Sergey Sharybin (sergey) requested changes to this revision.May 18 2020, 9:35 AM

Sergey Sharybin (sergey) added inline comments.

source/blender/editors/sculpt_paint/sculpt_pose.c
137	`const`
145–146	`unit_qt`
153	`const`
661–663	Why this and only this deformation need single segment?
723–726	This is the same code as above. Consider adding something like: static int pose_brush_num_effective_segments(const Brush brush) { / Explanation why this is a special case goes here. */ if (brush->pose_deform_type == BRUSH_POSE_DEFORM_SCALE_TRASLATE) { return 1; } return brush->pose_ik_segments; } This will also allow to have `const` qualifier for `tot_segments` here,
868–873	Avoid cases like if (condition) { // Many lines of code. } else { // Even more lines of code. } Those are two different distinct code paths, which can be easily moved to own functions.
919–921	What is this about?

This revision now requires changes to proceed.May 18 2020, 9:35 AM

Review Update

Harbormaster completed remote builds in B8108: Diff 24891.May 19 2020, 1:05 AM

From reading the code seems fine, can't spot any obvious issues.
Don't currently have time for user level test, so leaving this up to you ;) If you trust this works as expected go ahead with the commit.

This revision is now accepted and ready to land.May 19 2020, 12:59 PM

Closed by commit rB6d4dc22e17a7: Sculpt: Pose Brush Scale/Transform deform mode (authored by Pablo Dobarro (pablodp606)). · Explain WhyMay 25 2020, 5:36 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB6d4dc22e17a7: Sculpt: Pose Brush Scale/Transform deform mode.