Fix proposition for T75519
ClosedPublic
Actions

Authored by yves (valfeur) on Apr 9 2020, 5:39 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
William Reynish (billreynish)

Maniphest Tasks

T75519: Graph editor tooltips give false impression of the toggle state

Commits

rBaf876b12f1f7: Fix T75519: Graph editor tooltips give false impression of the toggle state

Summary

It is just a quick fix for the tooltips in the graph editor, it replaces:

"F-curve modifiers are disabled" with "Enable F-Curve modifiers"
"F-curve is visible in graph editor for editing" with "F-Curve visibility in Graph Editor".

However, "git diff" doesn't seem to take into account the files in "blender/release/datafiles/locale/po/" I don't really know if it should.

Diff Detail

Repository: rB Blender

Event Timeline

yves (valfeur) requested review of this revision.Apr 9 2020, 5:39 PM

yves (valfeur) created this revision.

yves (valfeur) retitled this revision from Fix proposition T75519 to Fix proposition for T75519.

Thx for this!
@Sybren A. Stüvel (sybren): I think it would make sense to go over other tooltips in draw_setting_widget as well?
For me, this could go in though, this is in line with other parts of blender (e.g. Outliner restrict buttons...)

Philipp Oeser (lichtwerk) added a task: T75519: Graph editor tooltips give false impression of the toggle state.Apr 9 2020, 5:54 PM

The first change seems fine.

The second one is a bit weird. It seems like you're enabling something in the interface to have modifiers disabled. We should make it so in the interface people enable option to enable modifier (unless it's already the case) and then the new wording would indeed be better.

In D7387#178282, @Sergey Sharybin (sergey) wrote:

The second one is a bit weird. It seems like you're enabling something in the interface to have modifiers disabled. We should make it so in the interface people enable option to enable modifier (unless it's already the case) and then the new wording would indeed be better.

In the Outliner, where something is visible by default [eye icon], we chose the the wording "Hide in Viewport"
In the Anim Channels, where the modifiers are enabled by default we should choose the wording "Disable F-Curve modifiers"?

(thinking about it more there is no real right or wrong: in both cases, using the verb will always be "wrong" in one state -- so I would actually prefer a noun like "visibility"... but we have this all over the interface, mostly with the verb hinting at doing the opposite of what the default is...)

Maybe @William Reynish (billreynish) has a rule here?

The old tooltips here are really bad. "F-Curve modifiers are disabled" is a bizarre statement in a tooltip, since that may well not be the case.

The last one can be used now, because the toggle was inverted for 2.8x.

This revision is now accepted and ready to land.Apr 15 2020, 1:40 PM

@Philipp Oeser (lichtwerk) indeed, it could read "Enable or disable F-Curve modifier".

Usually we use the positive state though - but in general we could go through and rename these tooltips so they always include both the positive and negative meaning - ie Show/Hide in Viewport etc.

Closed by commit rBaf876b12f1f7: Fix T75519: Graph editor tooltips give false impression of the toggle state (authored by rakk (yves), committed by Philipp Oeser (lichtwerk)). · Explain WhyApr 27 2020, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rBaf876b12f1f7: Fix T75519: Graph editor tooltips give false impression of the toggle state.