Page MenuHome

Fix T75526: Color Management Look saved in 2.82a resets after opening in 2.83
ClosedPublic

Authored by Germano Cavalcante (mano-wii) on Apr 9 2020, 8:10 PM.

Details

Summary

The solution is just a matter of versioning.
There must be better ways to edit these strings, therefore the review.

Ref T75526

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 7525
Build 7525: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.Apr 9 2020, 8:10 PM
Germano Cavalcante (mano-wii) created this revision.
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenloader/intern/versioning_280.c
4411–4418

This is slightly more correct and simpler:

for (Scene *scene = bmain->scenes.first; scene; scene = scene->id.next) {
  ColorManagedViewSettings *view_settings;
  view_settings = &scene->view_settings;
  if (BLI_str_startswith(view_settings->look, "Filmic - ")) {
    STRNCPY(view_settings->look, view_settings->look + strlen("Filmic - "));
  }
  else if (BLI_str_startswith(view_settings->look, "Standard - ")) {
    STRNCPY(view_settings->look, view_settings->look + strlen("Standard - "));
  }
}
This revision is now accepted and ready to land.Apr 9 2020, 9:27 PM
Germano Cavalcante (mano-wii) marked an inline comment as done.Apr 9 2020, 10:57 PM