Differential D7398

Fix for T75595: File Browser and Unicode Paths
ClosedPublic
Actions

Authored by Harley Acheson (harley) on Apr 10 2020, 10:14 PM.

Tags

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBa8d139ca2002: Fix for T75595: File Browser and Windows Unicode Paths

Summary

In order to call a unicode Windows API function (GetFileAttributesW) I was using BLI_strncpy_wchar_from_utf8() which doesn't work as expected on the Windows platform. It is creates integers (UTF32) and then asserting out when that won't fit into a wchar_t, which is 16-bit on Windows.

The fix is just to be more explicit in the conversion. I am needing UT16 so I get those exactly by using conv_utf_8_to_16() instead.

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.Apr 10 2020, 10:14 PM

Harley Acheson (harley) created this revision.

Harley Acheson (harley) mentioned this in T75595: File Browser Cannot Browse Unicode Folders.Apr 10 2020, 10:30 PM

Brecht Van Lommel (brecht) accepted this revision.Apr 10 2020, 10:35 PM

This revision is now accepted and ready to land.Apr 10 2020, 10:35 PM

Harley Acheson (harley) mentioned this in D7380: UI: Windows Shell Links & Improved Mac Aliases.Apr 10 2020, 10:37 PM

Closed by commit rBa8d139ca2002: Fix for T75595: File Browser and Windows Unicode Paths (authored by Harley Acheson (harley)). · Explain WhyApr 10 2020, 11:17 PM

This revision was automatically updated to reflect the committed changes.

Harley Acheson (harley) added a commit: rBa8d139ca2002: Fix for T75595: File Browser and Windows Unicode Paths.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenlib/

intern/

5 lines

Diff 23644

source/blender/blenlib/intern/storage.c

Loading...