Page MenuHome

Fix T75542: toggling modifier visibility not working correct with undo speedup
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Apr 11 2020, 9:23 PM.

Details

Summary

The problem is that in direct_link_id_restore_recalc, id_current->recalc_undo_accumulated should contain the changes from the target state to the current state. However it has already been cleared at this point, to start accumulating changes up to the next undo push.

Delaying the clear of this flag seems like the obvious solution, but it's hard to find the right place for that (if there is one). Instead this splits up the flag into two separate variables.

Diff Detail

Repository
rB Blender
Branch
undo-recalc (branched from master)
Build Status
Buildable 7546
Build 7546: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.Apr 11 2020, 9:23 PM

Yea, it's a bit unfortunate that we need so many recalc storage now, but cannot see any other way either... And it actually makes things a bit easier to follow too.

This revision is now accepted and ready to land.Apr 13 2020, 10:44 AM