Differential D7404

Fix T75566: Wacom tablet's side switches don't work
AbandonedPublic
Actions

Authored by Nicholas Rishel (nicholas_rishel) on Apr 12 2020, 7:04 AM.

Tags

None

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T75566: Wacom tablet's side switches don't work
Commits: rB7c84f254532e: Fix T75566

Summary

Button events now include tabletdata, so move is unnecessary.

Generate mouse button events when the system has an event but Wintab did not find a correlated event.

Only filter mouse button events, not Win32 Pointer events.

Signed-off-by: Nicholas Rishel <rishel.nick@gmail.com>
Fix T75566

Diff Detail

Repository

Branch

T75566 (branched from master)

Build Status

Buildable 7549
Build 7549: arc lint + arc unit

Event Timeline

Nicholas Rishel (nicholas_rishel) requested review of this revision.Apr 12 2020, 7:04 AM

Nicholas Rishel (nicholas_rishel) created this revision.

Harbormaster completed remote builds in B7549: Diff 23666.Apr 12 2020, 7:05 AM

Nicholas Rishel (nicholas_rishel) mentioned this in T75566: Wacom tablet's side switches don't work.Apr 12 2020, 7:05 AM

Ankit Meel (ankitm) retitled this revision from Fix T75566 to Fix T75566: Wacom tablet's side switches don't work.Apr 12 2020, 7:46 AM

Ankit Meel (ankitm) edited the summary of this revision. (Show Details)

Nicholas Rishel (nicholas_rishel) planned changes to this revision.Apr 12 2020, 8:39 AM

Postponing these changes until Wintab rewrite can be re-merged.

Allow double button up, otherwise there may be a trailing 0 pressure line.
Document inline that PACKETDATA and PACKETMODE modify external headers to
Mask all button down/up and switch back to using relative button input.
Move assignments into initializer list for GHOST_EventButton
Fix return value of WTPacketsGet.
Fix type for physicalButton in wintabMouseToGhost.
Revert "Mask all button down/up and switch back to using relative button input."
Change updateWintab interface to include whether window is visible so that
Correcting the type for indexing Wintab buttons.
Save Wintab packets to a local queue as WT_PACKET events arrive or when
Clarify comment to be more specific so that in the future someone knows
When there are not associated button events, assume there is no button
Adding explanitory comment to explain why tablet API check is necessary
Before a wintab button event is generated, generate a GHOST mouse move
In the case that a mouse move is generated by a tablet event, but the event

Harbormaster completed remote builds in B8207: Diff 25090.May 26 2020, 7:03 AM

Ack, arc diff didn't behave itself.

Nicholas Rishel (nicholas_rishel) abandoned this revision.May 26 2020, 7:20 AM

Nicholas Rishel (nicholas_rishel) added a commit: rB7c84f254532e: Fix T75566.Oct 31 2020, 12:32 AM

Revision Contents
Changeset List

Path

Size

intern/

ghost/

3 lines

intern/

GHOST_SystemWin32.h

11 lines

GHOST_SystemWin32.cpp

47 lines

Diff 23666

intern/ghost/GHOST_Types.h

Loading...

intern/ghost/intern/GHOST_SystemWin32.h

Loading...

intern/ghost/intern/GHOST_SystemWin32.cpp

Loading...