Differential D7412

Fix T75495: Blender crashes opening a VSE .blend file
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Apr 13 2020, 6:52 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T75495: Blender crashes opening a VSE .blend file having certain meta strips

Commits

rBdea1c1b9eb43: Fix T75495: Blender crashes opening a VSE .blend file

Summary

During scene copy modifier mask strips are relinked to point to strips in
new scene. If strip used as mask is in different seqbase, this can fail,
if seqbase is not copied yet.

Add SEQ_DUPE_IS_RECURSIVE_CALL to avoid relinking modifiers during recursive call.

Diff Detail

Repository

rB Blender

Branch

T75495 (branched from master)

Build Status

Buildable 7558
Build 7558: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Apr 13 2020, 6:52 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B7558: Diff 23695.Apr 13 2020, 6:53 PM

Brecht Van Lommel (brecht) added inline comments.Apr 13 2020, 8:53 PM

source/blender/blenkernel/intern/sequencer.c
5847–5848	This isn't really clear to me, are the links not fixed at all? Or is it more accurate to say something like? /* Fix modifier links recursively from the top level only, when all sequences have been copied. */