Fix T75567: Paint Mode Wireframe Incorrect
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Apr 14 2020, 9:36 AM.

Details

Reviewers

Maniphest Tasks

T75567: Paint Mask Selection wireframe is broken when the mesh is subdivided by either `Subdivision` or `Multires` modifiers

Commits

rBa703bbb4d71c: Fix T75567: Paint Mode Wireframe Incorrect

Summary

The loop normal VBO is used in two manners. In edit mode to draw the
edge normals. And in paint mode to draw the wireframe. This commit
checks which VBO is needed and build the correct one.

This allows show the wireframe correct in paint mode, when the object is
subdivided.

Diff Detail

Repository

rB Blender

Branch

T75567 (branched from master)

Build Status

Buildable 7566
Build 7566: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Apr 14 2020, 9:36 AM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B7566: Diff 23710.Apr 14 2020, 9:36 AM

Clément Foucault (fclem) accepted this revision.Apr 14 2020, 7:33 PM

This revision is now accepted and ready to land.Apr 14 2020, 7:33 PM

Closed by commit rBa703bbb4d71c: Fix T75567: Paint Mode Wireframe Incorrect (authored by Jeroen Bakker (jbakker)). · Explain WhyApr 16 2020, 8:35 AM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rBa703bbb4d71c: Fix T75567: Paint Mode Wireframe Incorrect.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_extract_mesh.c

18 lines

Diff 23710

View Options

source/blender/draw/intern/draw_cache_extract_mesh.c

Fix T75567: Paint Mode Wireframe IncorrectClosedPublicActions