This revision aims to simplify assets and platforms listing by integrating their boolean on the same label line as their name.
Details
Details
- Reviewers
Julian Eisel (Severin) Mitchell Stokes (moguri) - Group Reviewers
Game Engine - Commits
- rBAfa29de51d768: Game Engine Publishing: Integrated label checkbox
Diff Detail
Diff Detail
Event Timeline
Comment Actions
I feel the labels in addition to the check boxes clutter the UI. I think that the "Publish" label can be safely removed from the platforms list (tooltips can help people out here, but I find it should be intuitive). However, I'm not sure yet about the "Overwrite" labels in the Assets list. I'm also not sure if we want to move this check box into the list since it isn't really a enable/disable check box like the Platform one. If I disable the check box for an asset, it can still be copied, which feels unintuitive.
Overall, what I prefer (which might not necessarily be the right course of action):
- Remove labels for the Publish check box
- Remove changes to the Assets list
| game_engine_publishing.py | ||
|---|---|---|
| 510 | I would prefer if this stayed as "Overwrite Asset" since it is more descriptive. | |
Comment Actions
I agree with the changes requested by @Mitchell Stokes (moguri). The text takes up lots of horizontal space so we should get rid of it.
In case of the 'publish' buttons, I think it is fine to just leave the checkbox without text. It basically disables the item so it is intuitive and still makes sense without text. Further, I would move the checkbox in front of the item name.
The 'overwrite' checkbox is only an option for the item, it doesn't disable it, so just leaving out the text isn't a good solution. I would say we either remove the changes or find a descriptive icon for the option.
I'm also not sure if the 'Publish Default Platform" option should be in the same line as the 'Platforms' category label. As I understand it it's content of the category?
Comment Actions
Changed the UI_UL_list to use the folder path chooser. The "overwrite assets" toggle didn't make much sense to be in it.
I also have removed the "publish" toggle text, it makes for a cleaner look overall.
Comment Actions
The new changes look good. We probably don't need RENDER_UL_assets in this patch since it has no functional change, and could go into a patch that actually changes the drawing behavior of the list.
The "Default" Platform is what the old Save as Runtime addon used (the Blenderplayer that shipped with the build of Blender you're currently running). It is a fallback option that also allows users to use a similar workflow to the old addon. Depending on how you have your project or lib folder organized, you may or may not want to actually publish using this fallback platform. I expect users to use it when first using the addon but later disabling it when they get things setup.
As for what this means UI-wise for the option, I'm not sure, but I like the more compact UI that this patch offers.
Comment Actions
I also like the more compact look, but in this case it's a matter of hierarchy. The 'Publish Default Platform' is a part of the 'Platforms' category. In Blender that usually means it has to be put under it, not next to it.
Anyway, nit-picking here a bit, everything else seems fine (don't forget to get rid of RENDER_UL_assets)