Differential D7423

Enable the "Displace" modifier to work with curves.
Needs ReviewPublic
Actions

Authored by Damian (damian) on Apr 14 2020, 1:40 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Group Reviewers

Modifiers

Summary

I have found that simply adding the "eModifierTypeFlag_AcceptsCVs" flag to "Displace" modifier enables it for curves.

It works perfectly fine unless you press "Apply on spline" button. Blender crashes.
I'm not a developer, and unfortunately, I don't have a deep understanding of Blender code. So, any advice is welcome on how to catch and fix this exception.

Diff Detail

Repository: rB Blender

Event Timeline

Damian (damian) requested review of this revision.Apr 14 2020, 1:40 PM

Damian (damian) created this revision.

Seems fine. Will apply after the branching for 2.83 is done.

This revision is now accepted and ready to land.Apr 15 2020, 12:26 PM

This seems fine unless you enable the "Apply on spline" button. In my Blender builds it immediately crashes.
Unfortunately, I don't have good debugging skills to catch and fix this crash, though. My guess is that this modifier crashes when accessing a vertex group. Though, I don't know how to check it.

The changes to solve the crash went a bit deeper.

The comment in the code should explain it best.

@Damian (damian) can you test the updated patch?

Harbormaster completed remote builds in B7608: Diff 23821.Apr 16 2020, 4:14 PM

Duarte Farrajota Ramos (duarteframos) awarded a token.Apr 16 2020, 4:22 PM

Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).

In D7423#178767, @Sergey Sharybin (sergey) wrote:

The changes to solve the crash went a bit deeper.

The comment in the code should explain it best.

@Damian (damian) can you test the updated patch?

Still crushes the same way =((

That is weird. Seems to work for me. You sure you've applied an updated patch? What exact steps to reproduce the issue?

@Campbell Barton (campbellbarton), what do you think of the suggested changes?

In D7423#179016, @Sergey Sharybin (sergey) wrote:

That is weird. Seems to work for me. You sure you've applied an updated patch? What exact steps to reproduce the issue?

@Campbell Barton (campbellbarton), what do you think of the suggested changes?

I`ll double-check it again.

@Sergey Sharybin (sergey) I dont know, man. Blender still crashes when I hit "Apply on spline". The rest if working fine.

Not really sure why it will crash, and, unfortunately, don't really have time to dig deep.
Someone else's help from the modifiers project will be appreciated!

This revision now requires review to proceed.Mar 29 2021, 11:48 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

MOD_displace.c

2 lines

Diff 23721

View Options

source/blender/modifiers/intern/MOD_displace.c

Enable the "Displace" modifier to work with curves.Needs ReviewPublicActions