Page MenuHome
Differential D7428

Fix crash whith Simple Solidify and Bevel Convex
ClosedPublic
Actions

Authored by Henrik Dick (weasel) on Apr 14 2020, 6:47 PM.

Details

Reviewers
Bastien Montagne (mont29)
Group Reviewers
Modifiers
Commits
rB51e73e99569d: Fix crash whith Simple Solidify and Bevel Convex.
Summary

Fixed the crash when solidify was set to Simple with Fill Rim turned off and Bevel Convex used.

Also fixed that simple solidify would not set the bevel weight flag so the next modifier could use the bevel weights.

Simple cleanup with do_rim is also included.

Diff Detail

Repository
rB Blender

Event Timeline

Henrik Dick (weasel) requested review of this revision.Apr 14 2020, 6:47 PM
Henrik Dick (weasel) created this revision.
Henrik Dick (weasel) updated this revision to Diff 23735.Apr 14 2020, 6:50 PM
  • remembered to use clang format
  • made the inserted comment a proper comment with capital letter and period
Bastien Montagne (mont29) accepted this revision.Apr 15 2020, 10:55 AM
Bastien Montagne (mont29) added inline comments.
source/blender/modifiers/intern/MOD_solidify_extrude.c
239

== 0 is very important when assigning a bitflag check to a bool, since you have no other boolean operation. Otherwise, result is of type of the flag storage, and assigning to a bool will overflow in some cases (and you will get some wrong result then).

240

and this is wrong too actually, == 0 should only concern the bitwise &, not the boolean &&.

This revision is now accepted and ready to land.Apr 15 2020, 10:55 AM
Closed by commit rB51e73e99569d: Fix crash whith Simple Solidify and Bevel Convex. (authored by Henrik Dick (weasel), committed by Bastien Montagne (mont29)). · Explain WhyApr 15 2020, 11:09 AM
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added a commit: rB51e73e99569d: Fix crash whith Simple Solidify and Bevel Convex..
Henrik Dick (weasel) mentioned this in T81331: Complex Solidify TODO.Sep 30 2020, 6:36 PM

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
32 lines

Diff 23734

View Options

source/blender/modifiers/intern/MOD_solidify_extrude.c

Loading...