Page MenuHome
Differential D7432

Cleanup: remove (unused) RNA update cache
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 15 2020, 10:29 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rBec574b5b090f: Cleanup: remove (unused) RNA update cache
Summary

Introduced in 2011 in rB6a392e8cb505, it was disabled again soon after
in rBb062056c05a3 and traces to it partly removed in rB21744217cea9.

Now remove completely.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Apr 15 2020, 10:29 AM
Harbormaster completed remote builds in B7585: Diff 23753.Apr 15 2020, 10:29 AM
Philipp Oeser (lichtwerk) requested review of this revision.Apr 15 2020, 10:29 AM
Philipp Oeser (lichtwerk) mentioned this in T75686: Animating scene audio volume doesn't work.Apr 15 2020, 10:31 AM
Sergey Sharybin (sergey) accepted this revision.Apr 15 2020, 10:33 AM

We shouldn't be having partially working unused code.

If we ever need some sort of update cache it would need to have clear design first, and the code could be resurrected from history if needed.

This revision is now accepted and ready to land.Apr 15 2020, 10:33 AM
Closed by commit rBec574b5b090f: Cleanup: remove (unused) RNA update cache (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 15 2020, 5:09 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBec574b5b090f: Cleanup: remove (unused) RNA update cache.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
7 lines
3 lines
makesrna/
4 lines
intern/
111 lines

Diff 23768

View Options

source/blender/blenkernel/intern/anim_sys.c

Loading...
View Options

source/blender/blenkernel/intern/blendfile.c

Loading...
View Options

source/blender/makesrna/RNA_access.h

Loading...
View Options

source/blender/makesrna/intern/rna_access.c

Loading...