Strategy:
- Close existing diffs
- Create new branch
- Do improvements there
- Ask for review
Open Tasks:
- Are subscriptions with automatic and manual both supported by Braintree payment gateway?
- Verify missing geolocation tests
Details
Details
Diff Detail
Diff Detail
- Repository
- rL Looper
Event Timeline
| README.md | ||
|---|---|---|
| 9 | I think this is not the same as "subscriptions for which payment is directly managed by you". These three lines describe "automatic", "manual", and "managed". In your version, they describe "automatic", "manual", and "automatic or manual". | |
| README.md | ||
|---|---|---|
| 9 | Addressed in updated diff. | |
Comment Actions
- Update README.md
- Update README.md
- Update README.md
- Deps: Move attrs from dev to main
- Fix typo in README.md
- Add comment about "black" package
- Update .gitignore
- Fix typo
- Add EMAIL_SUPPORT setting
- Port Braintree token generation from blender-fund
Comment Actions
Lots of comments on what is my own code ;-)
| looper/views/add_payment_method.py | ||
|---|---|---|
| 93–97 ↗ | (On Diff #25666) | Constructing the error message from a gateway error should be a separate function. |
| looper/views/tokens.py | ||
| 41 ↗ | (On Diff #25666) | datetime.timedelta(minutes=10) should be stored in a 'constant' at the top of the file, so it can get a descriptive name, something like GATEWAY_TOKEN_EXPIRY. |
| tests/test_checkout.py | ||
| 60 ↗ | (On Diff #25666) | Rename test_client_token_happy to test_fresh_session |
| 70 ↗ | (On Diff #25666) | Rename to test_token_in_session__missing_expiry |
| 82 ↗ | (On Diff #25666) | Rename to test_token_in_session__expired |
| 94 ↗ | (On Diff #25666) | Rename to test_token_in_session__not_expired. |
| 97 ↗ | (On Diff #25666) | See comment above about the constant: here datetime.timedelta(minutes=5) should then be replaced with something like GATEWAY_TOKEN_EXPIRY / 2. |
| 104 ↗ | (On Diff #25666) | This comment is nonsense, it is trustworthy so the cached token should be used. |
Comment Actions
- Include devfund's GeoLite2;
- Address review comments:
- Better test names;
- Nonsensical comment removed.
Comment Actions
Patches linked from here were either salvaged in some form or abandoned, this can be closed now.