Page MenuHome
Differential D7463

Fix T75840: Add check for not generated edges
ClosedPublic
Actions

Authored by Henrik Dick (weasel) on Apr 17 2020, 9:59 PM.

Details

Reviewers
Bastien Montagne (mont29)
Group Reviewers
Modifiers
Maniphest Tasks
T75840: Solidify modifier - Only Rim crash in Complex mode
Commits
rB7865185d9865: Fix T75840: Add check for not generated edges
Summary

Fixes T75840

The value of new_edge is SOLIDIFY_EMPTY_TAG=2^32-1 if the edge is not generated. The code from D7334 was missing this check.

Diff Detail

Repository
rB Blender

Event Timeline

Henrik Dick (weasel) requested review of this revision.Apr 17 2020, 9:59 PM
Henrik Dick (weasel) created this revision.
Henrik Dick (weasel) edited the summary of this revision. (Show Details)
Henrik Dick (weasel) added a task: T75840: Solidify modifier - Only Rim crash in Complex mode.
Robert Guetzkow (rjg) awarded a token.Apr 18 2020, 11:35 AM
Henrik Dick (weasel) added a reviewer: Modifiers.Apr 20 2020, 10:20 AM
Bastien Montagne (mont29) accepted this revision.Apr 20 2020, 4:14 PM
This revision is now accepted and ready to land.Apr 20 2020, 4:14 PM
Closed by commit rB7865185d9865: Fix T75840: Add check for not generated edges (authored by Henrik Dick (weasel), committed by Bastien Montagne (mont29)). · Explain WhyApr 20 2020, 4:17 PM
This revision was automatically updated to reflect the committed changes.
Bastien Montagne (mont29) added a commit: rB7865185d9865: Fix T75840: Add check for not generated edges.

Revision Contents
Changeset List

PathSize
source/
blender/
modifiers/
intern/
8 lines

Diff 23906

View Options

source/blender/modifiers/intern/MOD_solidify_nonmanifold.c

Loading...