Differential D7472

Fix T75845: some dependencies update missing when painting textures.
ClosedPublic
Actions

Authored by Luc Revardel (lrevardel) on Apr 19 2020, 11:21 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T75845: Particle system doesn't update immediately according to texture properties

Commits

rB23919d2275f2: Fix T75845: some dependencies update missing when painting textures.

Summary

issue: Painting a texture that is set as a particle system influencer, doesn't
update particles. An external trigger (such as changing influence slider)
is required to update particles.

fix: The root cause is a missing relationship from image to texture in the
dependency graph.

test: Once fixed, image texture painting updates expected dependencies
such as particle system influence or displacement modifier.

Diff Detail

Repository

rB Blender

Branch

fix_T75845 (branched from master)

Build Status

Buildable 7644
Build 7644: arc lint + arc unit

Event Timeline

Luc Revardel (lrevardel) requested review of this revision.Apr 19 2020, 11:21 PM

Luc Revardel (lrevardel) created this revision.

Harbormaster completed remote builds in B7631: Diff 23880.Apr 19 2020, 11:21 PM

Luc Revardel (lrevardel) edited the summary of this revision. (Show Details)Apr 19 2020, 11:29 PM

Luc Revardel (lrevardel) mentioned this in T75845: Particle system doesn't update immediately according to texture properties.Apr 20 2020, 10:58 AM

Ankit Meel (ankitm) added a task: T75845: Particle system doesn't update immediately according to texture properties.Apr 20 2020, 11:02 AM

You shouldn't be iterating via users of image to tag them on image update, this should be handled by dependency graph.
So the root of the issue seems a missing dependency from image to texture. P1344 should give some hints what i mean exactly.

This revision now requires changes to proceed.Apr 20 2020, 12:05 PM

Vyacheslav (hitrpr) awarded a token.Apr 20 2020, 2:02 PM

Luc Revardel (lrevardel) mentioned this in D7479: Fix T75845: Particle system doesn't update immediately according to texture properties.Apr 20 2020, 9:13 PM

Update diffs based on code review comment.

The root cause is a missing relationship from image to texture in the
dependency graph.

@Sergey Sharybin (sergey) Sharybin (sergey): thanks for the corrective fix in P1344. Great mentoring, straight to the point. I have a much better understanding of how the dependency graph should be populated.

Harbormaster completed remote builds in B7644: Diff 23917.Apr 20 2020, 9:52 PM

Luc Revardel (lrevardel) edited the summary of this revision. (Show Details)Apr 20 2020, 9:54 PM

@Luc Revardel (lrevardel), if you've double-checked this patches fixes T75845 then it should be committed (in the middle of some other changes, so can't really easily test myself atm).
Do you have commit access btw?

This revision is now accepted and ready to land.Apr 21 2020, 8:54 AM

note to myself: check if this makes D5088: Fix T65889: Hair Particles not updating in Viewport when using Influence Textures (image sequences) obsolete (if it fixes T65889)

In D7472#179654, @Philipp Oeser (lichtwerk) wrote:

note to myself: check if this makes D5088: Fix T65889: Hair Particles not updating in Viewport when using Influence Textures (image sequences) obsolete (if it fixes T65889)

reply to myself: nope, that other report is still happening with this patch [TODO to myself: have a look at D5088 again]

In D7472#179637, @Sergey Sharybin (sergey) wrote:

@Luc Revardel (lrevardel), if you've double-checked this patches fixes T75845 then it should be committed (in the middle of some other changes, so can't really easily test myself atm).
Do you have commit access btw?

@Sergey Sharybin (sergey):
I don't have commit access.
Yes, I confirm that the patch fixes texture influence for hairs (using the file attached in bug report) but also displacement modifier.

In D7472#179656, @Philipp Oeser (lichtwerk) wrote:

In D7472#179654, @Philipp Oeser (lichtwerk) wrote:

note to myself: check if this makes D5088: Fix T65889: Hair Particles not updating in Viewport when using Influence Textures (image sequences) obsolete (if it fixes T65889)

reply to myself: nope, that other report is still happening with this patch [TODO to myself: have a look at D5088 again]

@Philipp Oeser (lichtwerk): I also tried the file from T65889 and I agree it doesn't fix it.
However, for T65889 I think you still need addition of Image->Texture relation (which is not created without this patch) so that the chain "Time Source -> Image -> Texture" triggers. So a combination of patches might work ?