Fix T75964: changing object's viewport display color does not update cycles
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 22 2020, 1:52 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Maniphest Tasks

T75964: changing an object's viewport display color does not auto update in viewport render mode.

Commits

rCc36e87f48156: Fix T75964: changing object's viewport display color does not update cycles
rB6c9a88234038: Fix T75964: changing object's viewport display color does not update

Summary

Caused by rB00466e756e33.

While that commit sounds logical, Cycles uses is_updated_transform() to
detect updates.

Suggest to either

introduce is_updated_shading() like this patch does or
tweak is_updated_transform() to include ID_RECALC_SHADING or
simply revert rB00466e756e33 [since it did not really fix anything

afaict]

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Apr 22 2020, 1:52 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B7677: Diff 23966.Apr 22 2020, 1:53 PM

I think this is fine.

This revision is now accepted and ready to land.Apr 22 2020, 2:18 PM

Sergey Sharybin (sergey) accepted this revision.Apr 22 2020, 2:29 PM

Closed by commit rB6c9a88234038: Fix T75964: changing object's viewport display color does not update (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 22 2020, 2:38 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB6c9a88234038: Fix T75964: changing object's viewport display color does not update.

Brecht Van Lommel (brecht) added a commit: rCc36e87f48156: Fix T75964: changing object's viewport display color does not update cycles.Jun 2 2020, 7:47 AM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

blender/

blender_sync.cpp

2 lines

source/

blender/

makesrna/

intern/

rna_depsgraph.c

11 lines

Diff 23971

View Options

intern/cycles/blender/blender_sync.cpp