Page MenuHome
Differential D7495

Fix T75977: Lower the merge limit in the bisect/mirror operation in symmetrize
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Apr 22 2020, 7:44 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Maniphest Tasks
T75977: Symmetrize on small objects destroys geometry
Commits
rBaa02a05bc7a8: Fix T75977: Lower the merge limit in the bisect/mirror operation in symmetrize
Summary

This operation is using the code of the mirror modifier, so no default
is guaranteed to work in all cases. This value matches the defaults of
the mirror modifier.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Apr 22 2020, 7:44 PM
Pablo Dobarro (pablodp606) created this revision.
Harbormaster completed remote builds in B7680: Diff 23977.Apr 22 2020, 7:44 PM
Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Apr 22 2020, 7:44 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Apr 22 2020, 9:12 PM

I think this should be an operator property, like Threshold on the mesh edit mode symmetrize operator.

Brandon (Brandon777) awarded a token.Apr 22 2020, 10:13 PM
Jeroen Bakker (jbakker) requested changes to this revision.Apr 30 2020, 8:50 AM

Yes, add this as a property as you mention that no default is guaranteed.

This revision now requires changes to proceed.Apr 30 2020, 8:50 AM
Pablo Dobarro (pablodp606) updated this revision to Diff 24649.May 12 2020, 2:42 AM
  • Add operator property for merge tolerance
Harbormaster completed remote builds in B8001: Diff 24649.May 12 2020, 2:42 AM
Jeroen Bakker (jbakker) requested changes to this revision.May 14 2020, 9:31 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
7491

"Distance within which symmetrical vertices are merged"

This revision now requires changes to proceed.May 14 2020, 9:31 AM
Pablo Dobarro (pablodp606) updated this revision to Diff 24890.May 19 2020, 12:15 AM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review update
Harbormaster completed remote builds in B8107: Diff 24890.May 19 2020, 12:15 AM
Jeroen Bakker (jbakker) accepted this revision.May 19 2020, 3:14 PM
This revision is now accepted and ready to land.May 19 2020, 3:14 PM
Closed by commit rBaa02a05bc7a8: Fix T75977: Lower the merge limit in the bisect/mirror operation in symmetrize (authored by Pablo Dobarro (pablodp606)). · Explain WhyMay 20 2020, 3:33 AM
This revision was automatically updated to reflect the committed changes.
Pablo Dobarro (pablodp606) added a commit: rBaa02a05bc7a8: Fix T75977: Lower the merge limit in the bisect/mirror operation in symmetrize.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
14 lines

Diff 24948

View Options

source/blender/editors/sculpt_paint/sculpt.c

Loading...