Fix T41471 Cycles Bake: Setting small tile size results in wrong bake with stripes rather than the expected noise pattern
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Aug 19 2014, 2:56 AM.

Details

Reviewers

Commits

rBS8d3cc431d7fd: Fix T41471 Cycles Bake: Setting small tile size results in wrong bake with…
rC8f8b7f52369b: Fix T41471 Cycles Bake: Setting small tile size results in wrong bake with…
rB8d3cc431d7fd: Fix T41471 Cycles Bake: Setting small tile size results in wrong bake with…

Summary

This problem was introduced in 983cbafd1877f8dbaae60b064a14e27b5b640f18
Basically the issue is that we were not getting a unique index in the
baking routine for the RNG (random number generator).

I will test it in CUDA tomorrow, but it should be working fine (it does in CPU).

Diff Detail

Repository: rB Blender

Event Timeline

Dalai Felinto (dfelinto) updated this revision to Diff 2456.Aug 19 2014, 2:56 AM

Dalai Felinto (dfelinto) retitled this revision from to Fix T41471 Cycles Bake: Setting small tile size results in wrong bake with stripes rather than the expected noise pattern.

Dalai Felinto (dfelinto) added a reviewer: Sergey Sharybin (sergey).

Dalai Felinto (dfelinto) updated this object.

Dalai Felinto (dfelinto) added subscribers: Andrea Weikert (elubie), Wolfgang Faehnle (mib2berlin).

By the way, @Daniel Salazar (zanqdo) confirme it works in his GPU too. @Sergey Sharybin (sergey) when you have a time to look at it, I would love to get this out of the way ;)

Seems fine, but please fix the alignment. In loads of places you've got something like

<tab><tab><tab>some_long_function_name(a, b,
<tab><tab><tab><tab><tab><tab><tab><tab>c);

should be:

<tab><tab><tab>some_long_funcition_name(a, b,
<tab><tab><tab><space><space><space>c);

This happens i.e. in device_cpu.cpp:324. This happens in laods of other palaces actually.

Accepting the revision hoping you'll fix the alignment before the commit.

This revision is now accepted and ready to land.Aug 19 2014, 10:50 AM

@Sergey Sharybin (sergey) this alignment with tab is what cycles is doing already. see device_cpu.cpp:226 or 248 or 291 ...
I know we don't do that in blender, but that seems to be Cycles style. Thoughts?