Differential D7502

Fix T76008: Fluid inflow with negative initial velocity is not working
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Apr 23 2020, 12:46 PM.

Details

Reviewers

Sebastián Barschkis (sebbas)

Maniphest Tasks

T76008: Fluid: Inflow with negative initial velocity is not working

Commits

rB6524aaf68563: Fix T76008: Fluid inflow with negative initial velocity is not working

Summary

This is a regression introduced in rBa0fe22095e6d9b8b194c2cf6f9a7c7b419d7e61c.

I changed it so that the velocity with the highest magnitude is considered and
not the highest value per coordinate.

Diff Detail

Repository

rB Blender

Branch

fluid-negative-initial-velocity (branched from master)

Build Status

Buildable 7688
Build 7688: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Apr 23 2020, 12:46 PM

Jacques Lucke (JacquesLucke) created this revision.

Jacques Lucke (JacquesLucke) added a task: T76008: Fluid: Inflow with negative initial velocity is not working.Apr 23 2020, 12:46 PM

Harbormaster completed remote builds in B7688: Diff 23998.Apr 23 2020, 12:46 PM

This revision is now accepted and ready to land.Apr 23 2020, 12:49 PM

Closed by commit rB6524aaf68563: Fix T76008: Fluid inflow with negative initial velocity is not working (authored by Jacques Lucke (JacquesLucke)). · Explain WhyApr 23 2020, 3:05 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB6524aaf68563: Fix T76008: Fluid inflow with negative initial velocity is not working.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

fluid.c

16 lines

Diff 23998

View Options

source/blender/blenkernel/intern/fluid.c

Fix T76008: Fluid inflow with negative initial velocity is not workingClosedPublicActions