Differential D7540

Fix T76131: Crash combing Hair using Python
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 27 2020, 11:39 AM.

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T76131: Reproducable Crash in Blender 2.83 Beta: Combing Hair using Python

Commits

rB4fd005fefb01: Fix T76131: Crash combing Hair using Python

Summary

Caused by rBe82827bf6ed5.

DRW_draw_depth_object calls DRW_mesh_batch_cache_create_requested with
NULL scene, but that is accessed later on...

Fallback to low quality extract in case we cannot access the setting.

Diff Detail

Repository

rB Blender

Branch

T76131 (branched from master)

Build Status

Buildable 7738
Build 7738: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Apr 27 2020, 11:39 AM

Harbormaster completed remote builds in B7738: Diff 24105.Apr 27 2020, 11:39 AM

Philipp Oeser (lichtwerk) requested review of this revision.Apr 27 2020, 11:39 AM

scene is actually available, pass that around instead of falling back to low quality extract...

Harbormaster completed remote builds in B7739: Diff 24106.Apr 27 2020, 11:50 AM

Philipp Oeser (lichtwerk) added a project: GPU / Viewport.Apr 27 2020, 11:52 AM

Clément Foucault (fclem) accepted this revision.Apr 27 2020, 1:08 PM

This revision is now accepted and ready to land.Apr 27 2020, 1:08 PM

Closed by commit rB4fd005fefb01: Fix T76131: Crash combing Hair using Python (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 27 2020, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB4fd005fefb01: Fix T76131: Crash combing Hair using Python.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

intern/

draw_cache_extract_mesh.c

2 lines

Diff 24105

View Options

source/blender/draw/intern/draw_cache_extract_mesh.c

Fix T76131: Crash combing Hair using PythonClosedPublicActions