Page MenuHome
Differential D7542

Armature posemode: add mouse independent "Select Linked" operator
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Apr 27 2020, 3:45 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Sybren A. Stüvel (sybren)
William Reynish (billreynish)
Maniphest Tasks
T76071: Pose: Select Linked does not work from menu
Commits
rBe07b245fe1f4: Armature posemode: add mouse independent "Select Linked" operator
Summary

The current "Select Linked" operator works based on mouse position and
makes no sense to call from the menus and was removed in rB536055e1ee0b.

This patch adds an operator independent from mouse position that just
selects all bones in relation to selected bones (and adds back menu
entries -- removal see D7543 --, adds keymap entry CTRL+L).

The original operator is renamed to 'select_linked_pick' internally
(this is now more in line to how "Select Linked" works for meshes,
curves etc)

ref T76071

Diff Detail

Repository
rB Blender
Branch
T76071_b (branched from master)
Build Status
Buildable 7749
Build 7749: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Apr 27 2020, 3:45 PM
Harbormaster completed remote builds in B7740: Diff 24108.Apr 27 2020, 3:45 PM
Philipp Oeser (lichtwerk) requested review of this revision.Apr 27 2020, 3:45 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Apr 27 2020, 3:49 PM
Philipp Oeser (lichtwerk) added projects: Animation & Rigging, User Interface.Apr 27 2020, 3:54 PM
Philipp Oeser (lichtwerk) mentioned this in rB536055e1ee0b: remove "Select Linked" from the posemode select menu.Apr 27 2020, 4:14 PM
Philipp Oeser (lichtwerk) mentioned this in T76071: Pose: Select Linked does not work from menu.Apr 27 2020, 4:16 PM
Aaron Carlisle (Blendify) added a subscriber: Aaron Carlisle (Blendify).Apr 27 2020, 10:50 PM

Seems to be missing the menu entree?

William Reynish (billreynish) accepted this revision.Apr 28 2020, 7:35 AM
This revision is now accepted and ready to land.Apr 28 2020, 7:35 AM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Apr 28 2020, 10:18 AM
Philipp Oeser (lichtwerk) updated this revision to Diff 24131.Apr 28 2020, 10:23 AM

actually add back menu entry (thx @Aaron Carlisle (Blendify) noting)

Harbormaster completed remote builds in B7749: Diff 24131.Apr 28 2020, 10:23 AM
Campbell Barton (campbellbarton) requested changes to this revision.EditedApr 28 2020, 10:30 AM

Minor issues otherwise LGTM.

Also, needs to be in menu:

diff --git a/release/scripts/startup/bl_ui/space_view3d.py b/release/scripts/startup/bl_ui/space_view3d.py
index 6c769e3b013..d7a063d09d1 100644
--- a/release/scripts/startup/bl_ui/space_view3d.py
+++ b/release/scripts/startup/bl_ui/space_view3d.py
@@ -1469,6 +1469,7 @@ class VIEW3D_MT_select_pose(Menu):
         layout.separator()
 
         layout.operator("pose.select_constraint_target", text="Constraint Target")
+        layout.operator("pose.select_linked", text="Linked")
 
         layout.separator()
source/blender/editors/armature/pose_select.c
490

Use PBONE_SELECTABLE, as the parent may not be on a visible layer.

512

This should be cutBone->next, otherwise only one of the children can be selected.

This revision now requires changes to proceed.Apr 28 2020, 10:30 AM
Philipp Oeser (lichtwerk) updated this revision to Diff 24132.Apr 28 2020, 10:51 AM
  • use PBONE_SELECTABLE
  • fix Select children loop w/ multiple immediate children
Harbormaster completed remote builds in B7750: Diff 24132.Apr 28 2020, 10:51 AM
Campbell Barton (campbellbarton) accepted this revision.Apr 29 2020, 10:22 AM
This revision is now accepted and ready to land.Apr 29 2020, 10:22 AM
Closed by commit rBe07b245fe1f4: Armature posemode: add mouse independent "Select Linked" operator (authored by Philipp Oeser (lichtwerk)). · Explain WhyApr 29 2020, 11:09 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBe07b245fe1f4: Armature posemode: add mouse independent "Select Linked" operator.
Tomas (Rusculleda) added a subscriber: Tomas (Rusculleda).May 1 2020, 6:13 PM

Hi! Ctrl+L in pose mode used to be "browse poses". It now calls "select linked" but in the keymap it is still assigned to both actions aparently. Will browse poses have a different shortcut?
Regards.

Philipp Oeser (lichtwerk) added a comment.May 1 2020, 8:14 PM
In D7542#182950, @Tomas (Rusculleda) wrote:

Hi! Ctrl+L in pose mode used to be "browse poses". It now calls "select linked" but in the keymap it is still assigned to both actions aparently. Will browse poses have a different shortcut?
Regards.

That is a good point, right now there is a conflict between the two [sorry for not noticing]
I assume browse poses is actually used more than select linked?
Select linked Ctrl+++L was chosen for consistency -- this is used like this every where: uv, maks, sequences, meshes, curves, armature editmode....
Since L is used for poselibs: we still have Alt+++Ctrl+L available, maybe use that?

@William Reynish (billreynish), @Sybren A. Stüvel (sybren): opinions?

William Reynish (billreynish) added a comment.May 1 2020, 9:08 PM

Indeed it’s best to use a consistent shortcut for Select Linked. We can move Browse Poses to some other shortcut. Do we use just P?

Philipp Oeser (lichtwerk) added a comment.May 1 2020, 9:55 PM

At the moment we have

  • Ctrl+P set parent
  • ⇧+P select parent
  • Alt+P propagate pose menu

So P alone would be free for browse poselib, but is then suddenly separated from the other poselib shortcuts... For poselib atm we have

  • Ctrl+L browse poselib CONFLICTS WITH SELECT LINKED
  • ⇧+L poselib add pose
  • Alt+L poselib remove pose
  • ⇧+Ctrl+L poselib rename pose

How about

  • Alt+L browse poselib
  • ⇧+L poselib add pose
  • ⇧+Alt+L poselib remove pose
  • ⇧+Ctrl+L poselib rename pose
William Reynish (billreynish) added a comment.May 2 2020, 8:29 AM

@Philipp Oeser (lichtwerk) fine with me

Philipp Oeser (lichtwerk) added subscribers: Hjalti Hjálmarsson (hjalti), Luciano Muñoz Sessarego (looch).May 6 2020, 9:53 AM
In D7542#182979, @Philipp Oeser (lichtwerk) wrote:

At the moment we have

  • Ctrl+P set parent
  • ⇧+P select parent
  • Alt+P propagate pose menu

So P alone would be free for browse poselib, but is then suddenly separated from the other poselib shortcuts... For poselib atm we have

  • Ctrl+L browse poselib CONFLICTS WITH SELECT LINKED
  • ⇧+L poselib add pose
  • Alt+L poselib remove pose
  • ⇧+Ctrl+L poselib rename pose

How about

  • Alt+L browse poselib
  • ⇧+L poselib add pose
  • ⇧+Alt+L poselib remove pose
  • ⇧+Ctrl+L poselib rename pose

Just double-checking with animation department: @Luciano Muñoz Sessarego (looch), @Hjalti Hjálmarsson (hjalti), @Sybren A. Stüvel (sybren) : are you OK with this?

Erick Tukuniata (erickblender) added a subscriber: Erick Tukuniata (erickblender).May 6 2020, 11:24 AM
In D7542#183895, @Philipp Oeser (lichtwerk) wrote:
In D7542#182979, @Philipp Oeser (lichtwerk) wrote:

At the moment we have

  • Ctrl+P set parent
  • ⇧+P select parent
  • Alt+P propagate pose menu

So P alone would be free for browse poselib, but is then suddenly separated from the other poselib shortcuts... For poselib atm we have

  • Ctrl+L browse poselib CONFLICTS WITH SELECT LINKED
  • ⇧+L poselib add pose
  • Alt+L poselib remove pose
  • ⇧+Ctrl+L poselib rename pose

How about

  • Alt+L browse poselib
  • ⇧+L poselib add pose
  • ⇧+Alt+L poselib remove pose
  • ⇧+Ctrl+L poselib rename pose

Just double-checking with animation department: @Luciano Muñoz Sessarego (looch), @Hjalti Hjálmarsson (hjalti), @Sybren A. Stüvel (sybren) : are you OK with this?

Yep, it makes sense. Thanks for taking care of it :)

Philipp Oeser (lichtwerk) mentioned this in rB18dbc8f5c158: Resolve keymap conflict for poselib.May 7 2020, 1:24 PM
Philipp Oeser (lichtwerk) added a comment.May 7 2020, 1:25 PM

Committed rB18dbc8f5c158: Resolve keymap conflict for poselib

Revision Contents
Changeset List

PathSize
release/
scripts/
presets/
keyconfig/
keymap_data/
3 lines
startup/
bl_ui/
1 line
source/
blender/
editors/
armature/
1 line
1 line
64 lines

Diff 24131

View Options

release/scripts/presets/keyconfig/keymap_data/blender_default.py

Loading...
View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...
View Options

source/blender/editors/armature/armature_intern.h

Loading...
View Options

source/blender/editors/armature/armature_ops.c

Loading...
View Options

source/blender/editors/armature/pose_select.c

Loading...