UI: Always Display World mist properties
ClosedPublic
Actions

Authored by Aaron Carlisle (Blendify) on Apr 28 2020, 12:03 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Julian Eisel (Severin)
Campbell Barton (campbellbarton)

Commits

rC544009d20120: UI: Use split layout for world mist settings
rBd2d3ab05b3b0: UI: Use split layout for world mist settings

Summary

The idea is to follow UI convention:

Use split layout
Nonblocking, mist can now be enabled from the panel header instead of going to the view layer properties to enable mist pass.
Always visible, this allows for feature discoverability and ease of set up

Before:

After:

Diff Detail

Repository: rB Blender

Event Timeline

Aaron Carlisle (Blendify) requested review of this revision.Apr 28 2020, 12:03 AM

Aaron Carlisle (Blendify) created this revision.

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)

Aaron Carlisle (Blendify) set the repository for this revision to rB Blender.

Aaron Carlisle (Blendify) added projects: BF Blender, Cycles, User Interface.

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)Apr 28 2020, 12:05 AM

Aaron Carlisle (Blendify) edited the summary of this revision. (Show Details)Apr 28 2020, 2:54 AM

Campbell Barton (campbellbarton) accepted this revision.Apr 29 2020, 11:01 AM

This revision is now accepted and ready to land.Apr 29 2020, 11:01 AM

Splitting out pass toggles to other parts of the interface is a bit odd (although arguably useful), I'm not so sure about this.

Otherwise this patch looks nice.

Campbell Barton (campbellbarton) resigned from this revision.Apr 29 2020, 11:04 AM

This revision now requires review to proceed.Apr 29 2020, 11:04 AM

Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).Apr 29 2020, 11:04 AM

@Campbell Barton (campbellbarton)

I was going to say exactly that. The layout of the properties here is nicer, but the pass toggle should stay in the Passes panel.

Arguably the mist pass properties would be more easily discovered if it were a sub-panel to the Passes panel, but I guess it is stored in the World datablock. The Mist pass tooltip could perhaps mention that you can tweak the pass in the World Properties.

Re always showing: Since this is only for *passes*, these controls simply don't do anything unless the Mist pass is enabled. Showing this panel always makes it seem like it's useful for something, which it is not.

This revision now requires changes to proceed.Apr 29 2020, 11:07 AM

@Julian Eisel (Severin) do you agree with William here? If so, how about we keep the panel visible but not active with a text label saying to enable the mist pass.

This revision now requires review to proceed.Sep 8 2020, 9:13 PM

I agree with William here. Improving the UI layout is fine, but other than that I think everything should be left in the same place.

The functionality here can be improved to be less confusing, but until that happens I don't think we should try to change the UI to mask the underlying design issue.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2020, 3:15 AM

Closed by commit rBd2d3ab05b3b0: UI: Use split layout for world mist settings (authored by Aaron Carlisle (Blendify)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rBd2d3ab05b3b0: UI: Use split layout for world mist settings.

Stefan Werner (swerner) added a commit: rC544009d20120: UI: Use split layout for world mist settings.Mar 1 2021, 2:18 AM