This adds an option in user preferences > themes > user interface to control the color of menu shadows.
Thanks to gdh, Severin and ideasman42 for help in irc :)
Diff Detail
Diff Detail
Event Timeline
This comment was removed by Kitt Zwovic (gandalf3).
This comment was removed by Kitt Zwovic (gandalf3).
Comment Actions
I don't have a strong opinion here, can you show an example of a theme where this makes a noticeable improvement?
Comment Actions
@Campbell Barton (campbellbarton) It's certainly not vital functionality, but rather like being able to adjust the shadows, especially on darker themes.
Here's an image comparing the default with different color shadows in different themes:
I especially like the effect of a subtly colorized shadow on a dark theme, as is done on back to black in the example image.
On the other themes, I experimented with a much brighter shadow on a dark theme and a colorized shadow on a light theme.
It's all very subjective whether these changes "improve" the theme, but at least the user would have the option to make such changes if they want to.
Comment Actions
Okay, should be fine then, made some minor notes,
| source/blender/editors/include/UI_resources.h | ||
|---|---|---|
| 267 | rather not call menu shadow, this is use for all kinds of popups right? - TH_UI_SHADOW ok? | |
| source/blender/editors/interface/interface_widgets.c | ||
| 2027 | In this case would use glColor4ub and convert (alphastep * (1.0f - expfac)) * 255.0f | |
| source/blender/makesdna/DNA_userdef_types.h | ||
| 118 | try avoid whitespace changes. | |
| 385 | again, this change is no use. | |
Comment Actions
Now the theme controls shadows behind nodes too. This might look a bit odd though, as node shadows are drawn behind the node, whereas menu shadows are completely transparent directly under the menu.
Not sure if this is okay or not, feedback is appreciated :)
| source/blender/editors/interface/interface_draw.c | ||
|---|---|---|
| 1732 ↗ | (On Diff #2653) | Currently none of the other parts of the code use UI_GetTheme, probably this should use TH_MENU_SHADOW |
Comment Actions
Use different function to get color from themes as requested by @Campbell Barton (campbellbarton)
Comment Actions
Review update
I talked about this to the other UI-geeks some weeks ago on IRC. We made the desicion to not allow any new theme options as long as the mess in the theme settings is not cleaned up a bit. However, in this case we could make an exception if the following two targets are met:
- the color is applied globally, so also for node shadows
- the color ereases the current shadow factor value (the fac/alpha can then be controlled via the 4. channel of the color value)
In this update I mainly did some minor cleanup and adressed the second point from above (the first one was already addressed in the original patch). The only "major" concern I currently have left is that we're missing a version bump. @Kitt Zwovic (gandalf3), I'll leave that for you, so I don't steal you all the fun ;) Hint: Look at init_userdef_do_versions() in resources.c.
Comment Actions
I've bumped the version, however I can't submit the patch as this revision is no longer in the list of available revisions to update.
Here's the diff anyway:
This comment was removed by Kitt Zwovic (gandalf3).
Comment Actions
Version bump.
I tested with and without bumping the subversion, and it seems like bumping the subversion is necessary.
Comment Actions
Just as a note, our current version code is messed up a bit and I'd like to wait with committing this until that has been fixed. This is partial being discussed on the mailing list, I'll commit fixes for the other part after that.
Comment Actions
Just going through some old patches.
I'd like to hear from Pablo and/or William if they find this theme option reasonable. If so, @Kitt Zwovic (gandalf3) would you be available to update this?
Comment Actions
I've been looking for a way to get rid of the shadow behind the nodes backdrop, or at least control the opacity of it, will this patch allow me to do that? (besides changing the color) @Kitt Zwovic (gandalf3)