Page MenuHome
Differential D7561

Overlays: Add Multires Levels info to Stats
Needs ReviewPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Apr 28 2020, 11:13 PM.
Tags
Subscribers
Bartosz Moniewski (monio)
Campbell Barton (campbellbarton)
Chris Kohl (ckohl_art)
Regnas (Regnas)
Sergey Sharybin (sergey)
Tokens
"100" token, awarded by Torrent."Like" token, awarded by cfnjrey."Burninate" token, awarded by andruxa696."Love" token, awarded by gilberto_rodrigues."Love" token, awarded by bnzs."Like" token, awarded by filibis."Like" token, awarded by Frozen_Death_Knight."Love" token, awarded by Rubens91."Love" token, awarded by johnsyed.

Details

Reviewers
Jeroen Bakker (jbakker)
William Reynish (billreynish)
Campbell Barton (campbellbarton)
Sergey Sharybin (sergey)
Summary

This adds an extra line to the Statistics overlay to display the active
sculpt level and the total number of levels when there is a Multires
modifier in the object is in Sculpt Mode.

With the current UI for switching levels it does not make much sense,
but the idea is to combine this with D7560 in order to control Multires
sculpting directly from the viewport, the same way the remesher can be
controlled. In that case, it is usefully to know how many levels the
object has and in which level you are in.

Diff Detail

Repository
rB Blender
Branch
sculpt-multires-stats (branched from master)
Build Status
Buildable 7775
Build 7775: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Apr 28 2020, 11:13 PM
Harbormaster completed remote builds in B7775: Diff 24175.Apr 28 2020, 11:13 PM
Pablo Dobarro (pablodp606) requested review of this revision.Apr 28 2020, 11:13 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Apr 28 2020, 11:14 PM
Pablo Dobarro (pablodp606) added reviewers: Jeroen Bakker (jbakker), William Reynish (billreynish).
babajan (johnsyed) awarded a token.Apr 29 2020, 5:39 AM
Andrey (andruxa696) awarded a token.Apr 29 2020, 7:38 AM
Campbell Barton (campbellbarton) requested changes to this revision.Apr 29 2020, 9:12 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

Looks fine, some minor notes.

source/blender/editors/space_info/info_stats.c
463

Return args should use r_ prefix.

635–636

SNPRINTF can be used here.

This revision now requires changes to proceed.Apr 29 2020, 9:12 AM
Sergey Sharybin (sergey) requested changes to this revision.Apr 29 2020, 9:13 AM
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/space_info/info_stats.c
463–480

No need to duplicate logic of looking for a multires modifier. It is implemented in get_multires_modifier.

635–636

BLI_snprintf

Pablo Dobarro (pablodp606) updated this revision to Diff 24209.Apr 29 2020, 6:52 PM
Pablo Dobarro (pablodp606) marked 4 inline comments as done.
  • Review Update
Harbormaster completed remote builds in B7798: Diff 24209.Apr 29 2020, 6:53 PM
Sergey Sharybin (sergey) accepted this revision.Apr 29 2020, 8:23 PM
Chris Kohl (ckohl_art) added a subscriber: Chris Kohl (ckohl_art).Apr 29 2020, 8:28 PM
William Reynish (billreynish) accepted this revision.Apr 30 2020, 10:59 PM
Vyacheslav (hitrpr) added a subscriber: Vyacheslav (hitrpr).May 1 2020, 8:43 PM

Why somebody need to know amount of vertices or edges in multires? Really?

Regnas (Regnas) added a subscriber: Regnas (Regnas).May 1 2020, 8:54 PM
In D7561#182963, @Vyacheslav (hitrpr) wrote:

Why somebody need to know amount of vertices or edges in multires? Really?

This is not what's happening here.
Read again.

Vyacheslav (hitrpr) added a comment.May 1 2020, 10:23 PM

@Regnas (Regnas) done it. And can`t understand, what you want to say.
There is no info in the posts, but I see in the code, that new info is just append to existing.
You are right.

Campbell Barton (campbellbarton) requested changes to this revision.May 4 2020, 7:08 AM
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/space_info/info_stats.c
471–472

No need for parenthesis on assignment.

635–636

SNPRINTF avoids redundant repetition here.

This revision now requires changes to proceed.May 4 2020, 7:08 AM
Pablo Dobarro (pablodp606) mentioned this in D7582: Multires: Delete Lower.May 5 2020, 5:12 PM
Pablo Dobarro (pablodp606) updated this revision to Diff 25265.May 30 2020, 10:15 PM
Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • Review update
Harbormaster completed remote builds in B8301: Diff 25265.May 30 2020, 10:15 PM
Vyacheslav (hitrpr) removed a subscriber: Vyacheslav (hitrpr).May 31 2020, 1:30 AM
Bartosz Moniewski (monio) added a subscriber: Bartosz Moniewski (monio).Jun 6 2020, 3:46 AM
Pablo Dobarro (pablodp606) mentioned this in T63745: Sculpt, Paint, Texture Module.Jun 8 2020, 7:53 PM
Ruben Dario Espinel Mora (Rubens91) awarded a token.Jun 8 2020, 8:29 PM
Jeroen Bakker (jbakker) added a project: BF Blender (2.90).Jun 9 2020, 7:42 AM
Kenn Nyström (Frozen_Death_Knight) awarded a token.Jun 10 2020, 7:09 PM
Emir Sinan Gürlek (filibis) awarded a token.Jun 10 2020, 8:16 PM
B (bnzs) awarded a token.Jun 12 2020, 3:41 AM
Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Jun 21 2020, 12:09 PM
Dalai Felinto (dfelinto) edited projects, added BF Blender; removed BF Blender (2.90).Aug 27 2020, 5:41 PM
Andrey (andruxa696) rescinded a token.Aug 28 2020, 4:33 PM
Andrey (andruxa696) awarded a token.
Aleksandr (cfnjrey) awarded a token.Sep 1 2020, 6:45 PM
Torrent (Torrent) awarded a token.Oct 19 2020, 4:00 AM
Jeroen Bakker (jbakker) added a parent revision: D7560: Object: Switch Subdivision Level operator.Oct 21 2020, 12:20 PM

I don't see any outstanding issues with this change. Except that the mentioned D7560: Object: Switch Subdivision Level operator is still under review, so this patch has still limited value. I added D7560 as parent to this change to reflect that

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_info/
29 lines

Diff 24175

View Options

source/blender/editors/space_info/info_stats.c

Loading...