Page MenuHome

Fix T71300: Crash on rendering scene recursively from sequencer
ClosedPublic

Authored by Richard Antalik (ISS) on Apr 29 2020, 5:18 AM.

Details

Summary

Adding recursive scenes has been disabled, but old files still can be opened.

Add check if scene will render itself.
Opening such file will produce warning on open and error on running render.

Diff Detail

Repository
rB Blender
Branch
T71300 (branched from master)
Build Status
Buildable 7782
Build 7782: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Apr 29 2020, 5:18 AM
Richard Antalik (ISS) created this revision.
  • remove versioning changes

Note that there could be an argument made for rendering anyway, just as we do for files with missing textures.

However, this is more of a corner case since only old files allow this situation.

This patch seems OK as is, however It could be good to include the strip name and frame number which conflicts so the user has some clue about what they need to fix.

There could even be an _ex version of BKE_sequencer_check_scene_recursion which takes an **r_seq argument so this information can be included in the report.

This revision is now accepted and ready to land.Apr 29 2020, 6:07 AM
  • Add possibility to render timeline without recursive scene strip, provide more info in error report

Note, that BKE_sequencer_check_scene_recursion is awful function to have in BKE, but I don't have a better place to put it in right now.

Also I am aiming for simplest possible solution here. I could check also if we are renedering single frame and stop render if there is only scene strip at cfra.
The more scenarios we want to cover precise solution gets more complex. I can do it, but I don't think it is necessary.