Windows: Move tbb to being dynamic library
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Apr 29 2020, 7:24 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Jeroen Bakker (jbakker)

Commits

rB33bdd91fb825: Windows: Move tbb to being dynamic library

Summary

Static tbb has always been frowned upon [1] sofar it has worked for us but
given our reliance on tbb is about to increase (D7475), I'd like to move the library
to more supported configuration. Which means moving it to be a dynamic library

I think I have been careful and have not broken any other platforms, but have
not tested this.

Landing this would involve new SVN libraries for everything that depends on tbb.

[1] https://www.threadingbuildingblocks.org/faq/there-version-tbb-provides-statically-linked-libraries

Merge remote-tracking branch 'origin/master' into tmp_dynamic_tbb

Diff Detail

Repository

rB Blender

Branch

tmp_dynamic_tbb (branched from master)

Build Status

Buildable 7866
Build 7866: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Apr 29 2020, 7:24 PM

Ray Molenkamp (LazyDodo) created this revision.

Harbormaster completed remote builds in B7799: Diff 24210.Apr 29 2020, 7:24 PM

Seems fine overall.

Is there a specific reason the debug library is named tbb_debug.dll rather than tbb.dll?

tbb internally counts on that name and uses it to ~~hint~~ tell the linker for the library to link from runtime_loader.h (which is used by a bunch of the tbb users like usd)

Ok, if that name is coming from TBB that's fine with me.

This revision is now accepted and ready to land.Apr 29 2020, 8:09 PM

Sergey Sharybin (sergey) accepted this revision.Apr 29 2020, 8:24 PM

Sybren A. Stüvel (sybren) awarded a token.May 1 2020, 10:28 AM

Merge remote-tracking branch 'origin/master' into tmp_dynamic_tbb
Fix openvdb build issue on debug
Add version information to the tbb dlls so the installer won't throw a fit during an upgrade

Harbormaster completed remote builds in B7847: Diff 24308.May 1 2020, 10:54 PM