Differential D7576
Snap: Allow multiple snap elements to be enabled without pressing Shift Authored by Germano Cavalcante (mano-wii) on Apr 30 2020, 3:44 PM.
Details
There is not much need to disable the previous snap element to enable another. At first this can be a little confusing, but you adapt quickly.
Diff Detail
Event TimelineComment Actions I like this a lot. Especially now that there is a more descriptive display to show which snap type is being used, it makes a lot of sense to have multiple snap elements enabled at the same time. My only concern is that this highlights the confusion of not displaying "shift click enums" differently from normal ones, but that' way out of scope with this patch. Comment Actions This would be good to improve, but we should do it in a generic way for all these kinds of 'multi-enum' controls. D7883 handles these cases instead. Comment Actions So when / if D7883 makes it in no changes would be needed here. Could abandon this at that point. |