GPencil: Include new Brush random curves
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Apr 30 2020, 4:36 PM.

Details

Reviewers

Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)
Pablo Vazquez (pablovazquez)

Group Reviewers

User Interface

Commits

rBb571516237a9: GPencil: Include new Brush random curves

Summary

Now the brushes have several new random settings and use curves to define the effect. The curves have been moved below the parameter to keep UI standards and extra curve panels have been removed.

The new curves are:

Hue.
Saturation.
Value.

New option to random at stroke level instead to random at point level for the following values:

Thickness.
Strength.
UV.
Hue.
Saturation.
Value.

Curves have been moved below the corresponding parameter and only are displayed in properties panel. Display the curves in the popover made it unusable.

Also, the Pressure random has been renamed to Radius because the old name was not clear enough.

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Apr 30 2020, 4:36 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B7823: Diff 24241.Apr 30 2020, 4:36 PM

Antonio Vazquez (antoniov) added reviewers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).Apr 30 2020, 4:40 PM

Antonio Vazquez (antoniov) added a project: Grease Pencil.

jorge (jorsh) awarded a token.Apr 30 2020, 4:52 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 1 2020, 9:35 AM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Cleanup: Delete unused code
GPencil: Rename Random Pressure to Radius

Harbormaster completed remote builds in B7834: Diff 24277.May 1 2020, 10:36 AM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 1 2020, 10:37 AM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)May 1 2020, 12:20 PM

Antonio Vazquez (antoniov) added a subscriber: Pablo Vazquez (pablovazquez).

Antonio Vazquez (antoniov) added a reviewer: User Interface.May 5 2020, 7:53 AM

@Pablo Vazquez (pablovazquez) @William Reynish (billreynish) any update here? I know that you talked with @Matias Mendiola (mendio) about UI and you agreed with the changes, but we need the official OK before moving to master

Love the feature, the Curves under the property might not be the proper solution but it's the best I can think of with the current UI toolkit Blender has.

So +1 from me to move this forward, and keeping it in the back of my mind on how we could tackle this in the future for other parts of Blender (I imagine we will use this concept a lot in texture painting as well, maybe @Pablo Dobarro (pablodp606) has UI ideas for this).

This revision is now accepted and ready to land.May 7 2020, 2:34 PM

Matias Mendiola (mendio) accepted this revision.May 7 2020, 2:48 PM

Closed by commit rBb571516237a9: GPencil: Include new Brush random curves (authored by Antonio Vazquez (antoniov)). · Explain WhyMay 7 2020, 3:11 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rBb571516237a9: GPencil: Include new Brush random curves.

Tony Reason (drpontchartrain) awarded a token.Dec 22 2022, 8:51 PM