Fix T76033: VSE crash with prefetch, disk cache and meta strips
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on May 1 2020, 4:22 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T76033: Video Sequence Editor crash with prefetch and meta strips

Commits

rB98990f6ba439: Fix T76033: VSE crash with prefetch, disk cache and meta strips

Summary

BKE_sequencer_prefetch_get_original_sequence() didn't look in metas
and returned NULL. This caused crash in disk cache that was trying to
read seq->name.

Add function that will look in meta strips recursively and condition
that seq must not be NULL.

Diff Detail

Repository

rB Blender

Branch

T76033 (branched from master)

Build Status

Buildable 7842
Build 7842: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.May 1 2020, 4:22 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B7842: Diff 24292.May 1 2020, 4:22 PM

Brecht Van Lommel (brecht) accepted this revision.May 1 2020, 4:24 PM

This revision is now accepted and ready to land.May 1 2020, 4:24 PM

source/blender/blenkernel/intern/seqprefetch.c:153:1: Control may reach end of non-void function
source/blender/blenkernel/intern/seqprefetch.c:139:13: Unused variable 'seq_orig'

Fix warnings

Harbormaster completed remote builds in B7845: Diff 24303.May 1 2020, 9:13 PM

Closed by commit rB98990f6ba439: Fix T76033: VSE crash with prefetch, disk cache and meta strips (authored by Richard Antalik (ISS)). · Explain WhyMay 1 2020, 9:24 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB98990f6ba439: Fix T76033: VSE crash with prefetch, disk cache and meta strips.

Vincent Blankfield (vvv) added a subscriber: Vincent Blankfield (vvv).May 2 2020, 12:39 AM

Vincent Blankfield (vvv) added inline comments.

source/blender/blenkernel/intern/seqcache.c
1295	Returning NULL instead of false here gives me a warning "C4047: 'return': 'bool' differs in levels of indirection from 'void *'" with VS2017 compiler.