NLA: Remain in tweak mode on new strip selection
AbandonedPublic
Actions

Authored by Wayde Moss (GuiltyGhost) on May 2 2020, 3:02 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)
William Reynish (billreynish)

Summary

This patch goes hand in hand with D7600: NLA: Always Show All Strips. It's been separated as a patch to avoid confusion in case one is accepted while the other is not. The following media has both patches applied.

Problem
Currently, when selecting a new strip, tweak mode is automatically exited leading to the current workflow:

Edit a NLA strip
Desire to edit a different layer
Exit tweak mode (tab or select empty space in NLA editor)
Look for and select new strip
Tab to enter tweak mode.

Solution
While in tweak mode, if the user selects a new strip, we remain in tweak mode.

Diff Detail

Repository

rB Blender

Branch

arcpatch-D7601 (branched from master)

Build Status

Buildable 9325
Build 9325: arc lint + arc unit

Event Timeline

Wayde Moss (GuiltyGhost) requested review of this revision.May 2 2020, 3:02 AM

Wayde Moss (GuiltyGhost) created this revision.

Harbormaster completed remote builds in B7852: Diff 24314.May 2 2020, 3:02 AM

Wayde Moss (GuiltyGhost) retitled this revision from NLA: Always Show All Strips and Sync Length Fix to NLA: Remain in tweak mode on new strip selection.May 2 2020, 3:08 AM

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)

Wayde Moss (GuiltyGhost) added a project: Animation & Rigging.

Wayde Moss (GuiltyGhost) added a subscriber: Animation & Rigging.

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)May 2 2020, 3:11 AM

Wayde Moss (GuiltyGhost) mentioned this in D7600: NLA: Always Show All Strips.

Wayde Moss (GuiltyGhost) mentioned this in D7532: NLA: Always Show All Strips and Sync Length Fix.May 2 2020, 3:31 AM

RedMser (RedMser) awarded a token.May 4 2020, 1:13 PM

RedMser (RedMser) added a subscriber: RedMser (RedMser).May 4 2020, 1:46 PM

Wayde Moss (GuiltyGhost) edited the summary of this revision. (Show Details)May 19 2020, 9:14 PM

Sybren A. Stüvel (sybren) added reviewers: Sybren A. Stüvel (sybren), William Reynish (billreynish).May 22 2020, 9:27 AM

rebase

Harbormaster completed remote builds in B9325: Diff 27380.Aug 4 2020, 10:01 AM

In hindsight, this is probably just as big of a hassle as the existing behavior. A better way would be to just do nothing on mouse click, including not exiting tweak mode on mouse click.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_nla/

nla_select.c

7 lines

Diff 27380

View Options

source/blender/editors/space_nla/nla_select.c

NLA: Remain in tweak mode on new strip selectionAbandonedPublicActions