Fix T76440: Follow Track -> Constraint to F-Curve has no effect
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on May 5 2020, 10:45 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Group Reviewers

VFX & Video

Maniphest Tasks

T76440: Follow Track -> Constraint to F-Curve has no effect

Commits

rBc57f65c088a9: Fix T76440: Follow Track -> Constraint to F-Curve has no effect

Summary

According to the logic of functions BKE_tracking_get_active_tracks or
BKE_tracking_object_get_tracks, tracking->tracks is only used when
the MovieTrackingObject chosen is of the type TRACKING_OBJECT_CAMERA.

The same logic should be used in python, so this patch proposes this.

Ref T76440

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) requested review of this revision.May 5 2020, 10:45 PM

Germano Cavalcante (mano-wii) created this revision.

Harbormaster completed remote builds in B7897: Diff 24419.May 5 2020, 10:45 PM

sanitize

Harbormaster completed remote builds in B7916: Diff 24448.May 6 2020, 2:02 PM

Sergey Sharybin (sergey) requested changes to this revision.May 6 2020, 3:34 PM

Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).

Sergey Sharybin (sergey) added inline comments.

release/scripts/startup/bl_operators/clip.py
493	Never catch generic exception, catch only what you expect to be a "good" failure. My guess is that you're trying to deal with possibly bad object name reference. Why not to do `tracking_object = clip.tracking.objects.get(con.object, None) ?
494	Give human readable and regular human being understandable error message. I am quite sure it's onyl a handful of artists for whom this error message will give clues.