Fix T36263: Pasted strip doesnt have F-Curve keyframes from the original
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on May 6 2020, 2:30 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T36263: Pasted strip doesnt have F-Curve keyframes from the original

Commits

rBeaee2b411935: Fix T36263: Pasted strip doesnt have F-Curve keyframes from the original

Summary

Original code for copying strips tried to change strip name 2 times before
copying and once again after pasting.

Store structs in clipboard in unchanged state, so we can reference data after
pasting easily.

Better method would probably be storing animation data in clipboard as well,
so we can copy animated strips even between scenes.

Diff Detail

Repository

rB Blender

Branch

T36263 (branched from master)

Build Status

Buildable 7918
Build 7918: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) created this revision.May 6 2020, 2:30 PM

Harbormaster completed remote builds in B7918: Diff 24450.May 6 2020, 2:30 PM

Richard Antalik (ISS) requested review of this revision.May 6 2020, 2:30 PM

Sounds reasonable.

Not sure what old code was trying to achieve here, so probably best is to give a good test and commit?

The code being removed was added in rB3d5898f3dcc5: Fix for [#25932] Video Sequencer: F-curve insertion failure after un-meta *… to fix T25932: Video Sequencer: F-curve insertion failure after un-meta.

Does that bug still exist with this patch?

In D7638#184061, @Brecht Van Lommel (brecht) wrote:

The code being removed was added in rB3d5898f3dcc5: Fix for [#25932] Video Sequencer: F-curve insertion failure after un-meta *… to fix T25932: Video Sequencer: F-curve insertion failure after un-meta.

Does that bug still exist with this patch?

It doesn't.
But it exists in 2.57 or 2.60. I don't think it was correct approach.

Right, I don't think that fix was correct either.

This revision is now accepted and ready to land.May 6 2020, 11:36 PM

Closed by commit rBeaee2b411935: Fix T36263: Pasted strip doesnt have F-Curve keyframes from the original (authored by Richard Antalik (ISS)). · Explain WhyMay 10 2020, 8:28 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rBeaee2b411935: Fix T36263: Pasted strip doesnt have F-Curve keyframes from the original.