Differential D7658
wayland: repeat key on key press and hold Authored by Christian Rauch (christian.rauch) on May 8 2020, 1:14 AM. Tags None Subscribers None Tokens
Details
This implements key repeats when a key is pressed and held. The key repeating is implemented via a GHOST timer which is enabled by switching to non-blocking event processing. This in turn fixes animation issues such as https://developer.blender.org/T76720.
Diff Detail
Event TimelineComment Actions I added a mutex to the GHOST_EventManager to synchronise the access to the event queue. This solves the issue with the NULL access. @Campbell Barton (campbellbarton) Can you have a look at this? Comment Actions @Campbell Barton (campbellbarton) @Brecht Van Lommel (brecht) Can you have a look at this, especially since it introduces a mutex in the event handler? Comment Actions I don't think using multithreading here will work well. GHOST is not designed to support sending events from threads. Care must also me taken to ensure events are passed in the right order, before/after other events. And to make sure the appropriate amount of events is sent even if the key up event is processed later than the actual time it happened. I think such events should somehow be generated in the same function that processes other events, checking elapsed timed. EDIT: nevermind, I misread the code here, wl_keyboard_listener is used for getting repeat event info. Still it may be useful to look at other implementations like https://github.com/glfw/glfw/pull/1210 that handle this without launching threads. Comment Actions This is now implemented via a GHOST_TimerTask. For this, I also had to change to a non-blocking loop, which as a side effect solves the animation issue in https://developer.blender.org/T76720. The most intrusive change is that I had to change the time source in GHOST from the CPU cycles spent in the process to a steady clock that accurately measures the time differences in real physical time.
Comment Actions @Campbell Barton (campbellbarton) Is this viable as is (independent key repeats) or do you need to have the X11 behaviour where only the last pressed key can repeat? Comment Actions @Christian Rauch (christian.rauch) the way key repeat works both on X11, Wayland (Weston), and non-graphical text mode (I assume Windows and MacOS too) is to only repeat the last pressed key. This is what users will expect when typing. I'd rather not introduce Wayland only keyboard behavior for now, and instead bring it to the same level as other platforms. More advanced functionality can always be considered once basics are working. Comment Actions I changed this back to a single timer that is reseted whenever a key, that can repeat, is pressed. Comment Actions @Campbell Barton (campbellbarton) @Brecht Van Lommel (brecht) Can you have a look at the key repeat timer again? Comment Actions | ||||||||||||||||||||