Fix T76512: Sculpt mode: crash when applying base
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on May 8 2020, 11:22 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Pablo Dobarro (pablodp606)

Maniphest Tasks

T76512: Sculpt mode: crash when applying base

Commits

rB86a16e7381ae: Fix T76512: Sculpt mode: crash when applying base

Diff Detail

Repository: rB Blender

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.May 8 2020, 11:22 AM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B7951: Diff 24517.May 8 2020, 11:23 AM

Note: it would be very helpful if someone will verify assumption that grids can be skipped from undo step if there is no PBVH when undo push is happening.
Alternative would be to ensure PBVH on undo push, but since this will introduce latency better not to do unless is really needed.

Sergey Sharybin (sergey) added a task: T76512: Sculpt mode: crash when applying base.May 8 2020, 3:29 PM

I can't think of a specific case where this would be an issue. If there are no grids then I think there would also be nothing that needs to be pushed, the mesh state would be fully recoverable from the mesh vertices and displacement layer.

This revision is now accepted and ready to land.May 8 2020, 3:37 PM

Closed by commit rB86a16e7381ae: Fix T76512: Sculpt mode: crash when applying base (authored by Sergey Sharybin (sergey)). · Explain WhyMay 11 2020, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB86a16e7381ae: Fix T76512: Sculpt mode: crash when applying base.