Page MenuHome
Differential D7669

IO: Move Abstract Hierarchy Iterator into `io/common`
ClosedPublic
Actions

Authored by Sybren A. Stüvel (sybren) on May 8 2020, 5:23 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Bastien Montagne (mont29)
Commits
rB084c5d6c7e2c: IO: Move Abstract Hierarchy Iterator into `io/common`
Summary

The goal of the AbstractHierarchyIterator class (and supporting classes) was to use it in different exporters. It shouldn't be part of the USD module + namespace any more.

The source files are moved into io/common, which is compiled & linked into a new library bf_io_common. The unittests are still inside the tests/gtests/usd directory. They should be moved to a separate test module too, but that will be delayed until after T73268 has been resolved.

This commit and the others in this topic offered for review are available in the temp-io-alembic-changes-up-to-D7672 branch.

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.May 8 2020, 5:23 PM
Sybren A. Stüvel (sybren) created this revision.
Harbormaster completed remote builds in B7959: Diff 24535.May 8 2020, 5:23 PM
Sybren A. Stüvel (sybren) updated this revision to Diff 24536.May 8 2020, 5:25 PM
  • Remove unnecessary include directories from CMakeLists.txt
Harbormaster completed remote builds in B7960: Diff 24536.May 8 2020, 5:25 PM
Sybren A. Stüvel (sybren) mentioned this in D7670: IO: Allow exporting a subset of the writers.May 8 2020, 5:33 PM
Sybren A. Stüvel (sybren) added projects: BF Blender, Pipeline, Assets & I/O.May 8 2020, 5:44 PM
Sybren A. Stüvel (sybren) mentioned this in D7664: Alembic: new exporter based on the USD exporter structure.May 8 2020, 5:49 PM
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)May 8 2020, 5:58 PM
Sybren A. Stüvel (sybren) updated this revision to Diff 25676.Jun 9 2020, 4:13 PM
Sybren A. Stüvel (sybren) edited the summary of this revision. (Show Details)
  • Changed namespace IO → blender::io after discussion on #blender-coders
Harbormaster completed remote builds in B8461: Diff 25676.Jun 9 2020, 4:13 PM
Bastien Montagne (mont29) accepted this revision.Jun 18 2020, 2:37 PM

LGTM, nothing much to say. ;)

This revision is now accepted and ready to land.Jun 18 2020, 2:37 PM
Closed by commit rB084c5d6c7e2c: IO: Move Abstract Hierarchy Iterator into `io/common` (authored by Sybren A. Stüvel (sybren)). · Explain WhyJun 19 2020, 10:26 AM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rB084c5d6c7e2c: IO: Move Abstract Hierarchy Iterator into `io/common`.

Revision Contents
Changeset List

PathSize
source/
blender/
io/
2 lines
alembic/
2 lines
common/
34 lines
common/
usd/
IO_abstract_hierarchy_iterator.h/
intern/
abstract_hierarchy_iterator.h
6 lines
intern/
8 lines
usd/
4 lines
intern/
6 lines
5 lines
tests/
gtests/
usd/
2 lines
4 lines
4 lines

Diff 26091

View Options

source/blender/io/CMakeLists.txt

Loading...
View Options

source/blender/io/alembic/CMakeLists.txt

Loading...
View Options

source/blender/io/common/CMakeLists.txt

Loading...
View Options

source/blender/io/common/IO_abstract_hierarchy_iterator.h

Loading...
View Options

source/blender/io/common/intern/abstract_hierarchy_iterator.cc

Loading...
View Options

source/blender/io/usd/CMakeLists.txt

Loading...
View Options

source/blender/io/usd/intern/abstract_hierarchy_iterator.h

Loading...
View Options

source/blender/io/usd/intern/abstract_hierarchy_iterator.cc

Loading...
View Options

source/blender/io/usd/intern/usd_hierarchy_iterator.h

Loading...
View Options

source/blender/io/usd/intern/usd_writer_abstract.h

Loading...
View Options

tests/gtests/usd/CMakeLists.txt

Loading...
View Options

tests/gtests/usd/abstract_hierarchy_iterator_test.cc

Loading...
View Options

tests/gtests/usd/hierarchy_context_order_test.cc

Loading...