Fix T75492: Only positive shrink factor values can be animated
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on May 11 2020, 6:12 PM.

Details

Reviewers

Sebastian Parborg (zeddb)

Maniphest Tasks

T75492: Only positive values of shrink factor can be animated

Commits

rBcfbcc94451c4: Fix T75492: Only positive shrink factor values can be animated

Summary

A better fix would probably be to check if the value is animated,
but I'm not sure how to do that.

The issue in the original file could also be fixed by enabling Dynamic Mesh.

Diff Detail

Repository

rB Blender

Branch

negative-shrink-factor (branched from master)

Build Status

Buildable 7996
Build 7996: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.May 11 2020, 6:12 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B7996: Diff 24625.May 11 2020, 6:12 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)May 11 2020, 6:14 PM

Jacques Lucke (JacquesLucke) added a reviewer: Sebastian Parborg (zeddb).

Jacques Lucke (JacquesLucke) added a task: T75492: Only positive values of shrink factor can be animated.

LGTM

This revision is now accepted and ready to land.May 12 2020, 12:15 PM

Closed by commit rBcfbcc94451c4: Fix T75492: Only positive shrink factor values can be animated (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMay 12 2020, 12:23 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBcfbcc94451c4: Fix T75492: Only positive shrink factor values can be animated.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

cloth.c

2 lines

Diff 24625

View Options

source/blender/blenkernel/intern/cloth.c

Fix T75492: Only positive shrink factor values can be animatedClosedPublicActions